Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: pkg/analysis_server/test/analysis/get_errors_test.dart

Issue 2884593003: Reverse the sense of the flag to make it easier to find test that need to be converted (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/get_hover_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test.analysis.get_errors; 5 library test.analysis.get_errors;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 8
9 import 'package:analysis_server/protocol/protocol.dart'; 9 import 'package:analysis_server/protocol/protocol.dart';
10 import 'package:analysis_server/protocol/protocol_generated.dart'; 10 import 'package:analysis_server/protocol/protocol_generated.dart';
11 import 'package:analysis_server/src/domain_analysis.dart'; 11 import 'package:analysis_server/src/domain_analysis.dart';
12 import 'package:test/test.dart'; 12 import 'package:test/test.dart';
13 import 'package:test_reflective_loader/test_reflective_loader.dart'; 13 import 'package:test_reflective_loader/test_reflective_loader.dart';
14 14
15 import '../analysis_abstract.dart'; 15 import '../analysis_abstract.dart';
16 16
17 main() { 17 main() {
18 defineReflectiveSuite(() { 18 defineReflectiveSuite(() {
19 defineReflectiveTests(GetErrorsTest); 19 defineReflectiveTests(GetErrorsTest);
20 }); 20 });
21 } 21 }
22 22
23 @reflectiveTest 23 @reflectiveTest
24 class GetErrorsTest extends AbstractAnalysisTest { 24 class GetErrorsTest extends AbstractAnalysisTest {
25 static const String requestId = 'test-getError'; 25 static const String requestId = 'test-getError';
26 26
27 @override 27 @override
28 bool get enableNewAnalysisDriver => false;
29
30 @override
28 void setUp() { 31 void setUp() {
29 super.setUp(); 32 super.setUp();
30 server.handlers = [ 33 server.handlers = [
31 new AnalysisDomainHandler(server), 34 new AnalysisDomainHandler(server),
32 ]; 35 ];
33 createProject(); 36 createProject();
34 } 37 }
35 38
36 test_afterAnalysisComplete() async { 39 test_afterAnalysisComplete() async {
37 addTestFile(''' 40 addTestFile('''
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 Request _createGetErrorsRequest(String file) { 145 Request _createGetErrorsRequest(String file) {
143 return new AnalysisGetErrorsParams(file).toRequest(requestId); 146 return new AnalysisGetErrorsParams(file).toRequest(requestId);
144 } 147 }
145 148
146 Future<List<AnalysisError>> _getErrors(String file) async { 149 Future<List<AnalysisError>> _getErrors(String file) async {
147 Request request = _createGetErrorsRequest(file); 150 Request request = _createGetErrorsRequest(file);
148 Response response = await serverChannel.sendRequest(request); 151 Response response = await serverChannel.sendRequest(request);
149 return new AnalysisGetErrorsResult.fromResponse(response).errors; 152 return new AnalysisGetErrorsResult.fromResponse(response).errors;
150 } 153 }
151 } 154 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analysis_server/test/analysis/get_hover_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698