Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: pkg/analysis_server/test/edit/refactoring_test.dart

Issue 2884593003: Reverse the sense of the flag to make it easier to find test that need to be converted (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/edit/refactoring_test.dart
diff --git a/pkg/analysis_server/test/edit/refactoring_test.dart b/pkg/analysis_server/test/edit/refactoring_test.dart
index 4574dd84d9115ed4124e433ad267f440fd3a8ba4..264fe0b3a70634e3b02ce2c07c1623844b34ebad 100644
--- a/pkg/analysis_server/test/edit/refactoring_test.dart
+++ b/pkg/analysis_server/test/edit/refactoring_test.dart
@@ -34,12 +34,6 @@ main() {
@reflectiveTest
class ConvertGetterMethodToMethodTest extends _AbstractGetRefactoring_Test {
- @override
- void setUp() {
- enableNewAnalysisDriver = true;
- super.setUp();
- }
-
test_function() {
addTestFile('''
int get test => 42;
@@ -137,12 +131,6 @@ main(A a, B b, C c, D d) {
@reflectiveTest
class ConvertMethodToGetterTest extends _AbstractGetRefactoring_Test {
- @override
- void setUp() {
- enableNewAnalysisDriver = true;
- super.setUp();
- }
-
test_function() {
addTestFile('''
int test() => 42;
@@ -257,6 +245,9 @@ main(A a, B b, C c, D d) {
@reflectiveTest
class ExtractLocalVariableTest extends _AbstractGetRefactoring_Test {
+ @override
+ bool get enableNewAnalysisDriver => false;
+
Future<Response> sendExtractRequest(
int offset, int length, String name, bool extractAll) {
RefactoringKind kind = RefactoringKind.EXTRACT_LOCAL_VARIABLE;
@@ -525,12 +516,6 @@ class ExtractMethodTest extends _AbstractGetRefactoring_Test {
String name = 'res';
ExtractMethodOptions options;
- @override
- void setUp() {
- enableNewAnalysisDriver = true;
- super.setUp();
- }
-
test_expression() {
addTestFile('''
main() {
@@ -798,7 +783,6 @@ class GetAvailableRefactoringsTest extends AbstractAnalysisTest {
@override
void setUp() {
- enableNewAnalysisDriver = true;
super.setUp();
createProject();
ExtensionManager manager = new ExtensionManager();
@@ -970,6 +954,9 @@ main() {
@reflectiveTest
class InlineLocalTest extends _AbstractGetRefactoring_Test {
+ @override
+ bool get enableNewAnalysisDriver => false;
+
test_analysis_onlyOneFile() async {
shouldWaitForFullAnalysis = false;
String otherFile = '$testFolder/other.dart';
@@ -1093,12 +1080,6 @@ main() {
class InlineMethodTest extends _AbstractGetRefactoring_Test {
InlineMethodOptions options = new InlineMethodOptions(true, true);
- @override
- void setUp() {
- enableNewAnalysisDriver = true;
- super.setUp();
- }
-
test_feedback() {
addTestFile('''
class A {
@@ -1228,6 +1209,9 @@ main() {
class MoveFileTest extends _AbstractGetRefactoring_Test {
MoveFileOptions options;
+ @override
+ bool get enableNewAnalysisDriver => false;
+
test_OK() {
resourceProvider.newFile('/project/bin/lib.dart', '');
addTestFile('''
@@ -1259,6 +1243,9 @@ import 'bin/lib.dart';
@reflectiveTest
class RenameTest extends _AbstractGetRefactoring_Test {
+ @override
+ bool get enableNewAnalysisDriver => false;
+
Future<Response> sendRenameRequest(String search, String newName,
{String id: '0', bool validateOnly: false}) {
RenameOptions options = newName != null ? new RenameOptions(newName) : null;
« no previous file with comments | « pkg/analysis_server/test/edit/organize_directives_test.dart ('k') | pkg/analysis_server/test/edit/sort_members_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698