Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2884473002: Revert of Add a default task runner argument to the constructor of JsonPrefStore. (Closed)

Created:
3 years, 7 months ago by Justin Donnelly
Modified:
3 years, 7 months ago
Reviewers:
gab, fdoray
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a default task runner argument to the constructor of JsonPrefStore. (patchset #3 id:40001 of https://codereview.chromium.org/2876643003/ ) Reason for revert: Broke compile step on ChromiumOS x86-generic Compile: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/ChromiumOS%20x86-generic%20Compile/builds/35463 Original issue's description: > Add a default task runner argument to the constructor of JsonPrefStore. > > Callers that don't need to run tasks on the same sequence as the > JsonPrefStore will be able to use the default argument. > > BUG=667892 > > Review-Url: https://codereview.chromium.org/2876643003 > Cr-Commit-Position: refs/heads/master@{#471428} > Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8c96b8ad8af9a TBR=gab@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892 Review-Url: https://codereview.chromium.org/2884473002 Cr-Commit-Position: refs/heads/master@{#471450} Committed: https://chromium.googlesource.com/chromium/src/+/1104930da3c75f52ec2c438d01c5b06850beb301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M components/prefs/json_pref_store.h View 2 chunks +7 lines, -13 lines 0 comments Download
M components/prefs/json_pref_store.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Justin Donnelly
Created Revert of Add a default task runner argument to the constructor of JsonPrefStore.
3 years, 7 months ago (2017-05-12 21:40:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884473002/1
3 years, 7 months ago (2017-05-12 21:41:20 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 21:42:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1104930da3c75f52ec2c438d01c5...

Powered by Google App Engine
This is Rietveld 408576698