|
|
Description[reland] Add a default task runner argument to the constructor of JsonPrefStore.
This was reverted because of a ChromeOS compile failure. The
compile failure was fixed by including "components/prefs/pref_filter.h"
Callers that don't need to run tasks on the same sequence as the
JsonPrefStore will be able to use the default argument.
BUG=667892
Review-Url: https://codereview.chromium.org/2876643003
Cr-Original-Commit-Position: refs/heads/master@{#471428}
Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8c96b8ad8af9a
Review-Url: https://codereview.chromium.org/2876643003
Cr-Commit-Position: refs/heads/master@{#471781}
Committed: https://chromium.googlesource.com/chromium/src/+/5f4a7a0bb70d7d0ad0027bf44d0640a5675bba94
Patch Set 1 #Patch Set 2 : self-review #Patch Set 3 : fix-build-error #Patch Set 4 : include preffilter #
Total comments: 1
Messages
Total messages: 33 (21 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fdoray@chromium.org changed reviewers: + gab@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494613127221540, "parent_rev": "57b0df585ca73e3c920515ad895a7e68ee0ef8db", "commit_rev": "22f197b4c0399140f9cf118136a8c96b8ad8af9a"}
Message was sent while issue was closed.
Description was changed from ========== Add a default task runner argument to the constructor of JsonPrefStore. Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 ========== to ========== Add a default task runner argument to the constructor of JsonPrefStore. Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2884473002/ by jdonnelly@chromium.org. The reason for reverting is: Broke compile step on ChromiumOS x86-generic Compile: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/ChromiumO....
Message was sent while issue was closed.
Description was changed from ========== Add a default task runner argument to the constructor of JsonPrefStore. Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ========== to ========== Add a default task runner argument to the constructor of JsonPrefStore. Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ==========
Description was changed from ========== Add a default task runner argument to the constructor of JsonPrefStore. Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ========== to ========== Add a default task runner argument to the constructor of JsonPrefStore. This was reverted because of a ChromeOS compile failure. The compile failure was fixed by including "components/prefs/pref_filter.h" Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ==========
Description was changed from ========== Add a default task runner argument to the constructor of JsonPrefStore. This was reverted because of a ChromeOS compile failure. The compile failure was fixed by including "components/prefs/pref_filter.h" Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ========== to ========== [reland] Add a default task runner argument to the constructor of JsonPrefStore. This was reverted because of a ChromeOS compile failure. The compile failure was fixed by including "components/prefs/pref_filter.h" Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ==========
The CQ bit was checked by fdoray@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org Link to the patchset: https://codereview.chromium.org/2876643003/#ps60001 (title: "include preffilter")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494860196041110, "parent_rev": "db69d6219c2103e298ab8262bf4a9cd05e870305", "commit_rev": "5f4a7a0bb70d7d0ad0027bf44d0640a5675bba94"}
Message was sent while issue was closed.
Description was changed from ========== [reland] Add a default task runner argument to the constructor of JsonPrefStore. This was reverted because of a ChromeOS compile failure. The compile failure was fixed by including "components/prefs/pref_filter.h" Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... ========== to ========== [reland] Add a default task runner argument to the constructor of JsonPrefStore. This was reverted because of a ChromeOS compile failure. The compile failure was fixed by including "components/prefs/pref_filter.h" Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Original-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8... Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471781} Committed: https://chromium.googlesource.com/chromium/src/+/5f4a7a0bb70d7d0ad0027bf44d06... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5f4a7a0bb70d7d0ad0027bf44d06...
Message was sent while issue was closed.
Post-commit nit after PS3 https://codereview.chromium.org/2876643003/diff/60001/components/prefs/json_p... File components/prefs/json_pref_store.cc (right): https://codereview.chromium.org/2876643003/diff/60001/components/prefs/json_p... components/prefs/json_pref_store.cc:29: #include "components/prefs/pref_filter.h" rm |