Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2876643003: [reland] Add a default task runner argument to the constructor of JsonPrefStore. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[reland] Add a default task runner argument to the constructor of JsonPrefStore. This was reverted because of a ChromeOS compile failure. The compile failure was fixed by including "components/prefs/pref_filter.h" Callers that don't need to run tasks on the same sequence as the JsonPrefStore will be able to use the default argument. BUG=667892 Review-Url: https://codereview.chromium.org/2876643003 Cr-Original-Commit-Position: refs/heads/master@{#471428} Committed: https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8c96b8ad8af9a Review-Url: https://codereview.chromium.org/2876643003 Cr-Commit-Position: refs/heads/master@{#471781} Committed: https://chromium.googlesource.com/chromium/src/+/5f4a7a0bb70d7d0ad0027bf44d0640a5675bba94

Patch Set 1 #

Patch Set 2 : self-review #

Patch Set 3 : fix-build-error #

Patch Set 4 : include preffilter #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M components/prefs/json_pref_store.h View 1 2 3 2 chunks +14 lines, -7 lines 0 comments Download
M components/prefs/json_pref_store.cc View 1 2 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 33 (21 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-11 17:47:43 UTC) #6
gab
lgtm
3 years, 7 months ago (2017-05-12 18:18:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876643003/40001
3 years, 7 months ago (2017-05-12 18:19:47 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/22f197b4c0399140f9cf118136a8c96b8ad8af9a
3 years, 7 months ago (2017-05-12 20:21:34 UTC) #14
Justin Donnelly
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2884473002/ by jdonnelly@chromium.org. ...
3 years, 7 months ago (2017-05-12 21:40:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876643003/60001
3 years, 7 months ago (2017-05-15 12:11:31 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/426487)
3 years, 7 months ago (2017-05-15 12:46:58 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876643003/60001
3 years, 7 months ago (2017-05-15 12:55:38 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/426562)
3 years, 7 months ago (2017-05-15 14:43:51 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876643003/60001
3 years, 7 months ago (2017-05-15 14:57:05 UTC) #29
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/5f4a7a0bb70d7d0ad0027bf44d0640a5675bba94
3 years, 7 months ago (2017-05-15 16:16:15 UTC) #32
gab
3 years, 7 months ago (2017-05-15 16:33:20 UTC) #33
Message was sent while issue was closed.
Post-commit nit after PS3

https://codereview.chromium.org/2876643003/diff/60001/components/prefs/json_p...
File components/prefs/json_pref_store.cc (right):

https://codereview.chromium.org/2876643003/diff/60001/components/prefs/json_p...
components/prefs/json_pref_store.cc:29: #include
"components/prefs/pref_filter.h"
rm

Powered by Google App Engine
This is Rietveld 408576698