VR: audio and video capture indicators.

VR: audio and video capture indicators.

- Created a SystemIndicatorTexture defined by an icon and message.
- Created UiElements and positioned them in the UiSceneManager.

BUG=

Review-Url: https://codereview.chromium.org/2884453002
Cr-Commit-Position: refs/heads/master@{#471836}
Committed: https://chromium.googlesource.com/chromium/src/+/67372f3c7eae35937bd6603450e17fd2a62e6cc8

[acondor_, 2017-05-12 19:11:21]

acondor@google.com changed reviewers:
+ mthiesse@chromium.org

[acondor_, 2017-05-12 19:11:22]

PTAL. Note that this CL depends on the new text rendering approach.

[mthiesse, 2017-05-12 19:44:50]

lgtm

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:115: element =
base::MakeUnique<AudioInputIndicator>(256);
Use 512 width like the permanent security warning? Was noticing quality issues
with anything less.

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:121:
scene_->AddUiElement(std::move(element));
Should hide these initially.

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:125:
element->set_translation({0.3, 0.8, -1.9});
Add TODO to not position them on top of each other when both should be visible.

[acondor_, 2017-05-12 20:09:51]

Waiting on the other CL to pass CQ.

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
File chrome/browser/android/vr_shell/ui_scene_manager.cc (right):

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:115: element =
base::MakeUnique<AudioInputIndicator>(256);
On 2017/05/12 19:44:50, mthiesse wrote:
> Use 512 width like the permanent security warning? Was noticing quality issues
> with anything less.

These are smaller and look perfect as is.

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:121:
scene_->AddUiElement(std::move(element));
On 2017/05/12 19:44:50, mthiesse wrote:
> Should hide these initially.

Done.

https://codereview.chromium.org/2884453002/diff/20001/chrome/browser/android/...
chrome/browser/android/vr_shell/ui_scene_manager.cc:125:
element->set_translation({0.3, 0.8, -1.9});
On 2017/05/12 19:44:50, mthiesse wrote:
> Add TODO to not position them on top of each other when both should be
visible.

The TODO above should cover this. Currently, one goes to the left side, and the
other to the right side.

[amp, 2017-05-12 21:05:10]

Just a quick thought (feel free to ignore), but 'input' makes me think these are
things that the user is inputing into Chrome.

I think the names were chosen from a viewpoint of VR shell (things being input
into the scene), but maybe 'output indicator' is more aligned with what the user
is doing?

Or am I missing the point of these entirely?

[amp, 2017-05-12 21:25:45]

On 2017/05/12 21:05:10, amp wrote:
> Just a quick thought (feel free to ignore), but 'input' makes me think these
are
> things that the user is inputing into Chrome.
> 
> I think the names were chosen from a viewpoint of VR shell (things being input
> into the scene), but maybe 'output indicator' is more aligned with what the
user
> is doing?
> 
> Or am I missing the point of these entirely?

Just saw the other review that clears this up.

Any reason not to name these video/audio 'capture' indicators to match the
internal concepts?

[acondor_, 2017-05-12 22:32:41]

On 2017/05/12 21:25:45, amp wrote:
> On 2017/05/12 21:05:10, amp wrote:
> > Just a quick thought (feel free to ignore), but 'input' makes me think these
> are
> > things that the user is inputing into Chrome.
> > 
> > I think the names were chosen from a viewpoint of VR shell (things being
input
> > into the scene), but maybe 'output indicator' is more aligned with what the
> user
> > is doing?
> > 
> > Or am I missing the point of these entirely?
> 
> Just saw the other review that clears this up.
> 
> Any reason not to name these video/audio 'capture' indicators to match the
> internal concepts?

The name came from the fact that audio/video "input" was being captured. But
yes, the name you suggest seems better.

[acondor_, 2017-05-13 00:39:16]

The CQ bit was checked by acondor@google.com

[acondor_, 2017-05-13 00:39:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2884453002/#ps60001
(title: "renaming input to capture")

[commit-bot: I haz the power, 2017-05-13 00:39:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:43:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-13 00:43:27]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[acondor_, 2017-05-15 14:06:37]

Description was changed from

==========
VR: audio and video input indicators.

- Created a SystemIndicatorTexture defined by an icon and message.
- Created UiElements and positioned them in the UiSceneManager.

BUG=
==========

to

==========
VR: audio and video capture indicators.

- Created a SystemIndicatorTexture defined by an icon and message.
- Created UiElements and positioned them in the UiSceneManager.

BUG=
==========

[acondor_, 2017-05-15 14:17:57]

The CQ bit was checked by acondor@google.com

[acondor_, 2017-05-15 14:17:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2884453002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-15 14:18:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 14:22:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 14:22:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[acondor_, 2017-05-15 16:51:00]

The CQ bit was checked by acondor@google.com

[acondor_, 2017-05-15 16:51:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org
Link to the patchset: https://codereview.chromium.org/2884453002/#ps100001
(title: "rebase 2")

[commit-bot: I haz the power, 2017-05-15 16:51:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 18:24:52]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494867060826690,
"parent_rev": "41b3811f190e351cd29a39589eb0aed8fdaedd8e", "commit_rev":
"67372f3c7eae35937bd6603450e17fd2a62e6cc8"}

[commit-bot: I haz the power, 2017-05-15 18:25:09]

Description was changed from

==========
VR: audio and video capture indicators.

- Created a SystemIndicatorTexture defined by an icon and message.
- Created UiElements and positioned them in the UiSceneManager.

BUG=
==========

to

==========
VR: audio and video capture indicators.

- Created a SystemIndicatorTexture defined by an icon and message.
- Created UiElements and positioned them in the UiSceneManager.

BUG=

Review-Url: https://codereview.chromium.org/2884453002
Cr-Commit-Position: refs/heads/master@{#471836}
Committed:
https://chromium.googlesource.com/chromium/src/+/67372f3c7eae35937bd6603450e1...
==========

[commit-bot: I haz the power, 2017-05-15 18:25:09]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/67372f3c7eae35937bd6603450e1...