VR: audio and video capture indicators.

chrome/browser/android/vr_shell/ui_scene_manager.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/ui_scene_manager.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/android/vr_shell/textures/ui_texture.h"
+#include "chrome/browser/android/vr_shell/ui_elements/audio_input_indicator.h"
 #include "chrome/browser/android/vr_shell/ui_elements/permanent_security_warning.h"
 #include "chrome/browser/android/vr_shell/ui_elements/transient_security_warning.h"
 #include "chrome/browser/android/vr_shell/ui_elements/ui_element.h"
 #include "chrome/browser/android/vr_shell/ui_elements/url_bar.h"
+#include "chrome/browser/android/vr_shell/ui_elements/video_input_indicator.h"
 #include "chrome/browser/android/vr_shell/ui_scene.h"
 #include "chrome/browser/android/vr_shell/vr_browser_interface.h"
 #include "chrome/browser/android/vr_shell/vr_shell.h"
 
 namespace vr_shell {
 
 namespace {
 
 static constexpr int kWarningTimeoutSeconds = 30;
 static constexpr float kWarningDistance = 0.7;
@@ skipping 36 matching lines @@
                                bool in_cct,
                                bool in_web_vr)
     : browser_(browser),
       scene_(scene),
       in_cct_(in_cct),
       web_vr_mode_(in_web_vr),
       weak_ptr_factory_(this) {
   CreateBackground();
   CreateContentQuad();
   CreateSecurityWarnings();
+  CreateSystemIndicators();
   CreateUrlBar();
 }
 
 UiSceneManager::~UiSceneManager() {}
 
 void UiSceneManager::CreateSecurityWarnings() {
   std::unique_ptr<UiElement> element;
 
   // TODO(mthiesse): Programatically compute the proper texture size for these
   // textured UI elements.
@@ skipping 18 matching lines @@
   element->set_size({kTransientWarningWidth, kTransientWarningHeight, 1});
   element->set_scale({kWarningDistance, kWarningDistance, 1});
   element->set_translation({0, 0, -kWarningDistance});
   element->set_visible(false);
   element->set_hit_testable(false);
   element->set_lock_to_fov(true);
   transient_security_warning_ = element.get();
   scene_->AddUiElement(std::move(element));
 }
 
+void UiSceneManager::CreateSystemIndicators() {
+  std::unique_ptr<UiElement> element;
+
+  // TODO(acondor): Make constants for sizes and positions once the UX for the
+  // indicators is defined.
+  element = base::MakeUnique<AudioInputIndicator>(256);

[mthiesse, 2017/05/12 19:44:50]

Use 512 width like the permanent security warning? Was noticing quality issues
with anything less.

[acondor_, 2017/05/12 20:09:51]

These are smaller and look perfect as is.

+  element->set_id(AllocateId());
+  element->set_translation({-0.3, 0.8, -1.9});
+  element->set_size({0.4, 0, 1});
+  audio_input_indicator_ = element.get();
+  browser_ui_elements_.push_back(element.get());
+  scene_->AddUiElement(std::move(element));

[mthiesse, 2017/05/12 19:44:50]

Should hide these initially.

[acondor_, 2017/05/12 20:09:51]

Done.

+
+  element = base::MakeUnique<VideoInputIndicator>(256);
+  element->set_id(AllocateId());
+  element->set_translation({0.3, 0.8, -1.9});

[mthiesse, 2017/05/12 19:44:50]

Add TODO to not position them on top of each other when both should be visible.

[acondor_, 2017/05/12 20:09:51]

The TODO above should cover this. Currently, one goes to the left side, and the
other to the right side.

+  element->set_size({0.4, 0, 1});
+  audio_input_indicator_ = element.get();
+  browser_ui_elements_.push_back(element.get());
+  scene_->AddUiElement(std::move(element));
+
+  // TODO(asimjour): Hook system updates to show/hide indicators.
+}
+
 void UiSceneManager::CreateContentQuad() {
   std::unique_ptr<UiElement> element;
 
   element = base::MakeUnique<UiElement>();
   element->set_id(AllocateId());
   element->set_fill(vr_shell::Fill::CONTENT);
   element->set_size({kContentWidth, kContentHeight, 1});
   element->set_translation({0, kContentVerticalOffset, -kContentDistance});
   element->set_visible(false);
   main_content_ = element.get();
@@ skipping 175 matching lines @@
 void UiSceneManager::SetLoadProgress(double progress) {}
 
 void UiSceneManager::SetHistoryButtonsEnabled(bool can_go_back,
                                               bool can_go_forward) {}
 
 int UiSceneManager::AllocateId() {
   return next_available_id_++;
 }
 
 }  // namespace vr_shell