Issue 2884363002: TabManager: Remove a redundant log line which produces excessive log.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2884363002: TabManager: Remove a redundant log line which produces excessive log. (Closed)

Created:
3 years, 7 months ago by cylee1

Modified:
3 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/branch-heads/3071

Project:
chromium

Visibility:
Public.

TabManager: Remove a redundant log line which produces excessive log. KillTab() returns false on valid cases, so useless to report it. BUG=chromium:721632 TEST=manual Review-Url: https://codereview.chromium.org/2879673004 Cr-Original-Commit-Position: refs/heads/master@{#471470} Review-Url: https://codereview.chromium.org/2884363002 . Cr-Commit-Position: refs/branch-heads/3071@{#586} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1dbb725b409a99fb67d9250618c7ccdc92aafc07

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/memory/tab_manager_delegate_chromeos.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

cylee1

3 years, 7 months ago (2017-05-16 17:58:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1dbb725b409a99fb67d9250618c7ccdc92aafc07.