TabManager: Remove a redundant log line which produces excessive log.

TabManager: Remove a redundant log line which produces excessive log.

KillTab() returns false on valid cases, so useless to report it.

BUG=chromium:721632
TEST=manual

Review-Url: https://codereview.chromium.org/2879673004
Cr-Commit-Position: refs/heads/master@{#471470}
Committed: https://chromium.googlesource.com/chromium/src/+/9c5c339f64135eedc7af11876f52a23fda402b15

[cylee1, 2017-05-12 20:44:53]

cylee@chromium.org changed reviewers:
+ sonnyrao@chromium.org, teravest@chromium.org, yusukes@chromium.org

[cylee1, 2017-05-12 20:46:21]

The CQ bit was checked by cylee@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 20:47:04]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-05-12 20:47:08]

https://codereview.chromium.org/2879673004/diff/1/chrome/browser/memory/tab_m...
File chrome/browser/memory/tab_manager_delegate_chromeos.cc (left):

https://codereview.chromium.org/2879673004/diff/1/chrome/browser/memory/tab_m...
chrome/browser/memory/tab_manager_delegate_chromeos.cc:640: MEMORY_LOG(ERROR) <<
"Failed to kill " << *it;
What about changing this to VLOG? For debugging purposes, we might still want to
see it.

[teravest, 2017-05-12 20:59:06]

lgtm

I think we may as well remove this in its current state. 

Maybe we could bring it back (or add it to VLOG) if we had more info like the
reason why we didn't kill the tab.

[cylee1, 2017-05-12 21:04:40]

https://codereview.chromium.org/2879673004/diff/1/chrome/browser/memory/tab_m...
File chrome/browser/memory/tab_manager_delegate_chromeos.cc (left):

https://codereview.chromium.org/2879673004/diff/1/chrome/browser/memory/tab_m...
chrome/browser/memory/tab_manager_delegate_chromeos.cc:640: MEMORY_LOG(ERROR) <<
"Failed to kill " << *it;
On 2017/05/12 20:47:08, Yusuke Sato wrote:
> What about changing this to VLOG? For debugging purposes, we might still want
to
> see it.

Personally I don't think so. 
Particularly a tab is always in |candidates| no matter discarded or not. It
means for example there're 20 tabs and 10 of them are already discarded. For
each of following low memory event, those 10 tabs would still be scanned, each
producing a spam log line. 
For it to be informative, I think we should print the exact reason why it can't
be discarded (e.g., already discarded? active tab ? audio tab? etc). I think
it's not our priority at this stage.

[Yusuke Sato, 2017-05-12 21:07:39]

ok, let's land it as-is. lgtm.

[commit-bot: I haz the power, 2017-05-12 21:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 21:40:32]

Dry run: This issue passed the CQ dry run.

[cylee1, 2017-05-12 22:22:53]

The CQ bit was checked by cylee@chromium.org

[commit-bot: I haz the power, 2017-05-12 22:24:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 22:36:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494627773106890, "parent_rev":
"112f8bb218e9d837f06102584a59b1fd9b2d2895", "commit_rev":
"06a05dc1bd5f4cb0f6597a541033dd4eeb234c03"}

[commit-bot: I haz the power, 2017-05-12 22:36:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494627773106890, "parent_rev":
"f9738b1996eeecdc9b66a1296dc96460adac6268", "commit_rev":
"9c5c339f64135eedc7af11876f52a23fda402b15"}

[commit-bot: I haz the power, 2017-05-12 22:37:07]

Description was changed from

==========
TabManager: Remove a redundant log line which produces excessive log.

KillTab() returns false on valid cases, so useless to report it.

BUG=chromium:721632
TEST=manual
==========

to

==========
TabManager: Remove a redundant log line which produces excessive log.

KillTab() returns false on valid cases, so useless to report it.

BUG=chromium:721632
TEST=manual

Review-Url: https://codereview.chromium.org/2879673004
Cr-Commit-Position: refs/heads/master@{#471470}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c5c339f64135eedc7af11876f52...
==========

[commit-bot: I haz the power, 2017-05-12 22:37:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c5c339f64135eedc7af11876f52...