Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2884303002: android: Remove _apk_run targets (Closed)

Created:
3 years, 7 months ago by Nico
Modified:
3 years, 7 months ago
Reviewers:
Dirk Pranke, jbudorick
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Remove _apk_run targets They should no longer be needed after https://codereview.chromium.org/2851523002 and https://chromium-review.googlesource.com/497271 BUG=716117 Review-Url: https://codereview.chromium.org/2884303002 Cr-Commit-Position: refs/heads/master@{#472244} Committed: https://chromium.googlesource.com/chromium/src/+/024d6f363dd7ca1b91a39ec6565edfa1b796ed24

Patch Set 1 #

Patch Set 2 : mb #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M testing/test.gni View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/mb/mb.py View 1 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Nico
Is this safe now?
3 years, 7 months ago (2017-05-16 16:39:01 UTC) #3
jbudorick
lgtm On 2017/05/16 16:39:01, Nico wrote: > Is this safe now? I think so. Can ...
3 years, 7 months ago (2017-05-16 16:53:40 UTC) #5
Nico
On Tue, May 16, 2017 at 12:53 PM, <jbudorick@chromium.org> wrote: > lgtm > > On ...
3 years, 7 months ago (2017-05-16 17:04:29 UTC) #7
jbudorick
On 2017/05/16 17:04:29, Nico wrote: > On Tue, May 16, 2017 at 12:53 PM, <mailto:jbudorick@chromium.org> ...
3 years, 7 months ago (2017-05-16 17:37:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884303002/20001
3 years, 7 months ago (2017-05-16 17:44:47 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/438586)
3 years, 7 months ago (2017-05-16 18:22:31 UTC) #15
Nico
+dpranke for testing/OWNERS
3 years, 7 months ago (2017-05-16 18:32:31 UTC) #17
Dirk Pranke
lgtm
3 years, 7 months ago (2017-05-16 22:32:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884303002/20001
3 years, 7 months ago (2017-05-16 23:05:48 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/024d6f363dd7ca1b91a39ec6565edfa1b796ed24
3 years, 7 months ago (2017-05-16 23:22:00 UTC) #23
findit-for-me
3 years, 7 months ago (2017-05-17 09:46:31 UTC) #24
Message was sent while issue was closed.
Findit (https://goo.gl/kROfz5) identified this CL at revision 472244 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Powered by Google App Engine
This is Rietveld 408576698