|
|
Descriptionandroid: Remove _apk_run targets
They should no longer be needed after https://codereview.chromium.org/2851523002
and https://chromium-review.googlesource.com/497271
BUG=716117
Review-Url: https://codereview.chromium.org/2884303002
Cr-Commit-Position: refs/heads/master@{#472244}
Committed: https://chromium.googlesource.com/chromium/src/+/024d6f363dd7ca1b91a39ec6565edfa1b796ed24
Patch Set 1 #Patch Set 2 : mb #
Messages
Total messages: 24 (13 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + jbudorick@chromium.org
Is this safe now?
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm On 2017/05/16 16:39:01, Nico wrote: > Is this safe now? I think so. Can you remove _apk_run from https://codesearch.chromium.org/chromium/src/tools/mb/mb.py?rcl=582a408839872..., too?
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
On Tue, May 16, 2017 at 12:53 PM, <jbudorick@chromium.org> wrote: > lgtm > > On 2017/05/16 16:39:01, Nico wrote: > > Is this safe now? > > I think so. Can you remove _apk_run from > https://codesearch.chromium.org/chromium/src/tools/mb/mb.py?rcl= > 582a4088398728aa9b1ab672dd92ecc9b9d589db&l=956, > too? > I think that whole function can go now, right? Done. -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/16 17:04:29, Nico wrote: > On Tue, May 16, 2017 at 12:53 PM, <mailto:jbudorick@chromium.org> wrote: > > > lgtm > > > > On 2017/05/16 16:39:01, Nico wrote: > > > Is this safe now? > > > > I think so. Can you remove _apk_run from > > https://codesearch.chromium.org/chromium/src/tools/mb/mb.py?rcl= > > 582a4088398728aa9b1ab672dd92ecc9b9d589db&l=956, > > too? > > > > I think that whole function can go now, right? Done. afaict yeah. > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org.
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbudorick@chromium.org Link to the patchset: https://codereview.chromium.org/2884303002/#ps20001 (title: "mb")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
thakis@chromium.org changed reviewers: + dpranke@chromium.org
+dpranke for testing/OWNERS
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494975811845270, "parent_rev": "4eea68788021df0f3aaf0ad7caea8043f9142617", "commit_rev": "024d6f363dd7ca1b91a39ec6565edfa1b796ed24"}
Message was sent while issue was closed.
Description was changed from ========== android: Remove _apk_run targets They should no longer be needed after https://codereview.chromium.org/2851523002 and https://chromium-review.googlesource.com/497271 BUG=716117 ========== to ========== android: Remove _apk_run targets They should no longer be needed after https://codereview.chromium.org/2851523002 and https://chromium-review.googlesource.com/497271 BUG=716117 Review-Url: https://codereview.chromium.org/2884303002 Cr-Commit-Position: refs/heads/master@{#472244} Committed: https://chromium.googlesource.com/chromium/src/+/024d6f363dd7ca1b91a39ec6565e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/024d6f363dd7ca1b91a39ec6565e...
Message was sent while issue was closed.
Findit (https://goo.gl/kROfz5) identified this CL at revision 472244 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb... |