Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tools/mb/mb.py

Issue 2884303002: android: Remove _apk_run targets (Closed)
Patch Set: mb Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/test.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb.py
diff --git a/tools/mb/mb.py b/tools/mb/mb.py
index 11a30f390e88faae97a24277c186e36850b7ceae..1debfb0af2c54d38ee911eda4f6821397d747d27 100755
--- a/tools/mb/mb.py
+++ b/tools/mb/mb.py
@@ -952,12 +952,6 @@ class MetaBuildWrapper(object):
labels = []
err = ''
- def StripTestSuffixes(target):
- for suffix in ('_apk_run', '_apk', '_run'):
- if target.endswith(suffix):
- return target[:-len(suffix)], suffix
- return None, None
-
for target in targets:
if target == 'all':
labels.append(target)
@@ -965,14 +959,10 @@ class MetaBuildWrapper(object):
labels.append(target)
else:
if target in isolate_map:
- stripped_target, suffix = target, ''
- else:
- stripped_target, suffix = StripTestSuffixes(target)
- if stripped_target in isolate_map:
- if isolate_map[stripped_target]['type'] == 'unknown':
+ if isolate_map[target]['type'] == 'unknown':
err += ('test target "%s" type is unknown\n' % target)
else:
- labels.append(isolate_map[stripped_target]['label'] + suffix)
+ labels.append(isolate_map[target]['label'])
else:
err += ('target "%s" not found in '
'//testing/buildbot/gn_isolate_map.pyl\n' % target)
« no previous file with comments | « testing/test.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698