Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/WebKit/Source/core/dom/NodeFilter.idl

Issue 2884263002: NodeFilter#acceptNode argument node should not be optional (Closed)
Patch Set: Removing the FIXME comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/NodeFilter.idl
diff --git a/third_party/WebKit/Source/core/dom/NodeFilter.idl b/third_party/WebKit/Source/core/dom/NodeFilter.idl
index b4d6ccb6e3aaefd420e52ba0cf40ab3839c57930..7b7090543b96dad8042200a07df52d147eecdcb7 100644
--- a/third_party/WebKit/Source/core/dom/NodeFilter.idl
+++ b/third_party/WebKit/Source/core/dom/NodeFilter.idl
@@ -46,6 +46,5 @@
// This function declaration doesn't generate any code because
// V8NodeFilterCondition represents this callback interface in Blink.
// TODO(bashi): Fix crbug.com/630986, and use generated code.
- // FIXME: The node argument should not be optional.
- [RaisesException] unsigned short acceptNode([Default=Undefined] optional Node node);
+ [RaisesException] unsigned short acceptNode([Default=Undefined] Node node);
tkent 2017/05/19 07:18:47 Please remove [Default=Undefined] too. It's an ex
};
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698