Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2884253002: Remove v8.google benchmark (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove v8.google benchmark The adwords JS bechmarking is already covered by adwords page in v8.runtime_stats.top_25 benchmark (See https://cs.chromium.org/chromium/src/tools/perf/page_sets/v8_top_25.py?l=52) BUG=721413 Review-Url: https://codereview.chromium.org/2884253002 Cr-Commit-Position: refs/heads/master@{#472408} Committed: https://chromium.googlesource.com/chromium/src/+/3b4c47659ea48f66c256654e99950e9511b520ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1274 lines, -2659 lines) Patch
M testing/buildbot/chromium.perf.json View 438 chunks +1273 lines, -2394 lines 0 comments Download
M testing/buildbot/chromium.perf.fyi.json View 3 chunks +0 lines, -177 lines 0 comments Download
M tools/perf/benchmark.csv View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/benchmarks/v8.py View 2 chunks +1 line, -54 lines 0 comments Download
D tools/perf/page_sets/data/v8_pages.json View 1 chunk +0 lines, -9 lines 0 comments Download
D tools/perf/page_sets/data/v8_pages_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/google_pages.py View 2 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
nednguyen
3 years, 7 months ago (2017-05-16 13:23:27 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-17 07:32:36 UTC) #8
Camillo Bruni
lgtm
3 years, 7 months ago (2017-05-17 08:03:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2884253002/20001
3 years, 7 months ago (2017-05-17 10:11:04 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 10:16:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3b4c47659ea48f66c256654e9995...

Powered by Google App Engine
This is Rietveld 408576698