Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2884253002: Remove v8.google benchmark (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/page_sets/data/v8_pages.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index 5ca5cde0d8437d8e70e42facb11425bb6094535a..d8699282afaa09e4673cb1f33cc181584d2e97a0 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -1,33 +1,19 @@
# Copyright 2014 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import os
-
-from core import path_util
from core import perf_benchmark
-from page_sets import google_pages
from benchmarks import v8_helper
from measurements import v8_detached_context_age_in_gc
import page_sets
+
from telemetry import benchmark
-from telemetry import story
from telemetry.timeline import chrome_trace_category_filter
from telemetry.timeline import chrome_trace_config
from telemetry.web_perf import timeline_based_measurement
-def CreateV8TimelineBasedMeasurementOptions():
- category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter()
- category_filter.AddIncludedCategory('v8')
- category_filter.AddIncludedCategory('blink.console')
- category_filter.AddDisabledByDefault('disabled-by-default-v8.compile')
- options = timeline_based_measurement.Options(category_filter)
- options.SetTimelineBasedMetrics(['executionMetric'])
- return options
-
-
@benchmark.Owner(emails=['ulan@chromium.org'])
class V8DetachedContextAgeInGC(perf_benchmark.PerfBenchmark):
"""Measures the number of GCs needed to collect a detached context.
@@ -186,45 +172,6 @@ class V8MobileInfiniteScrollClassic(V8MobileInfiniteScroll):
def Name(cls):
return 'v8.mobile_infinite_scroll-classic_tbmv2'
-@benchmark.Owner(emails=['hablich@chromium.org'])
-class V8Adword(perf_benchmark.PerfBenchmark):
- """Measures V8 Execution metrics on the Adword page."""
-
- options = {'pageset_repeat': 3}
-
- def CreateTimelineBasedMeasurementOptions(self):
- return CreateV8TimelineBasedMeasurementOptions()
-
- def CreateStorySet(self, options):
- """Creates the instance of StorySet used to run the benchmark.
-
- Can be overridden by subclasses.
- """
- story_set = story.StorySet(
- archive_data_file=os.path.join(
- path_util.GetPerfStorySetsDir(), 'data', 'v8_pages.json'),
- cloud_storage_bucket=story.PARTNER_BUCKET)
- story_set.AddStory(google_pages.AdwordCampaignDesktopPage(story_set))
- return story_set
-
- @classmethod
- def Name(cls):
- return 'v8.google'
-
- @classmethod
- def ShouldDisable(cls, possible_browser):
- if cls.IsSvelte(possible_browser): # http://crbug.com/596556
- return True
- # http://crbug.com/623576
- if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
- possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
- return True
- return False
-
- @classmethod
- def ShouldTearDownStateAfterEachStoryRun(cls):
- return True
-
class _Top25RuntimeStats(perf_benchmark.PerfBenchmark):
options = {'pageset_repeat': 3}
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/page_sets/data/v8_pages.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698