Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2884203002: cros: Stop showing migration UI in some conditions where users can't start ARC. (Closed)

Created:
3 years, 7 months ago by fukino
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

cros: Stop showing migration UI in some conditions where users can't start ARC. In following cases, we don't need to force dircrypto since ARC can not run. Let's not show the migration UI in such cases. 1) When a user is logging in to the account to add an supervised user. 2) When a user is logging in as a secondary user in multi-profile sessoin. These conditions do not affect the banners on user pods. BUG=721622, 721623 TEST=manually tested the cases listed in the CL description. Review-Url: https://codereview.chromium.org/2877943002 Cr-Original-Commit-Position: refs/heads/master@{#471658} Review-Url: https://codereview.chromium.org/2884203002 . Cr-Commit-Position: refs/branch-heads/3071@{#577} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/93ece3922ada41c1f763201d8b8e1a04cd40c3af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
fukino
3 years, 7 months ago (2017-05-16 08:58:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93ece3922ada41c1f763201d8b8e1a04cd40c3af.

Powered by Google App Engine
This is Rietveld 408576698