Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 2877943002: cros: Stop showing migration UI in some conditions where users can't start ARC. (Closed)

Created:
3 years, 7 months ago by fukino
Modified:
3 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, kinaba
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Stop showing migration UI in some conditions where users can't start ARC. In following cases, we don't need to force dircrypto since ARC can not run. Let's not show the migration UI in such cases. 1) When a user is logging in to the account to add an supervised user. 2) When a user is logging in as a secondary user in multi-profile sessoin. These conditions do not affect the banners on user pods. BUG=721622, 721623 TEST=manually tested the cases listed in the CL description. Review-Url: https://codereview.chromium.org/2877943002 Cr-Commit-Position: refs/heads/master@{#471658} Committed: https://chromium.googlesource.com/chromium/src/+/77f5935267dfb3f96b9194b18e9b824ba086ea74

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +25 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
fukino
Xiyuan, could you take a look?
3 years, 7 months ago (2017-05-12 09:24:16 UTC) #3
xiyuan
lgtm
3 years, 7 months ago (2017-05-12 16:25:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2877943002/1
3 years, 7 months ago (2017-05-15 03:13:17 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 04:07:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77f5935267dfb3f96b9194b18e9b...

Powered by Google App Engine
This is Rietveld 408576698