Move RareInheritedData (Quotes|Shadow)DataEquivalent to ComputedStyle.

Move RareInheritedData (Quotes|Shadow)DataEquivalent to ComputedStyle.

Currently, RareInheritedData has two helper functions:
QuotesDataEquivalent and ShadowDataEquivalent. When we generate
RareInheritedData, these helpers will no longer exist, so we need
to move them to CopmutedStyle.

This patch moves RareInheritedData::QuotesDataEquivalent and
RareInheritedData::ShadowDataEquivalent to ComputedStyle. It also
renames ShadowDataEquivalent to TextShadowDataEquivalent since it is
comparing text-shadow.

BUG=628043
Review-Url: https://codereview.chromium.org/2884153002
Cr-Commit-Position: refs/heads/master@{#472425}
Committed: https://chromium.googlesource.com/chromium/src/+/ae9de50e595b29c947d00c8f652e8ac3ab41f768

[shend, 2017-05-16 02:35:18]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 02:35:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shend, 2017-05-16 02:37:04]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-05-16 02:37:05]

Hi Naina, PTAL

[nainar, 2017-05-16 02:44:26]

lgtm please add the reasoning for this change to the CL description.

[shend, 2017-05-16 02:48:17]

Description was changed from

==========
Move RareInheritedData (Quotes|Shadow)DataEquivalent to ComputedStyle.

This patch moves RareInheritedData::QuotesDataEquivalent and
RareInheritedData::ShadowDataEquivalent to ComputedStyle. It also
renames ShadowDataEquivalent to TextShadowDataEquivalent since it is
comparing text-shadow.

BUG=628043
==========

to

==========
Move RareInheritedData (Quotes|Shadow)DataEquivalent to ComputedStyle.

Currently, RareInheritedData has two helper functions:
QuotesDataEquivalent and ShadowDataEquivalent. When we generate
RareInheritedData, these helpers will no longer exist, so we need
to move them to CopmutedStyle.

This patch moves RareInheritedData::QuotesDataEquivalent and
RareInheritedData::ShadowDataEquivalent to ComputedStyle. It also
renames ShadowDataEquivalent to TextShadowDataEquivalent since it is
comparing text-shadow.

BUG=628043
==========

[shend, 2017-05-16 02:48:45]

shend@chromium.org changed reviewers:
+ meade@chromium.org

[shend, 2017-05-16 02:48:45]

Done, thanks. Eddy, PTAL :)

[commit-bot: I haz the power, 2017-05-16 04:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 04:23:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[meade_UTC10, 2017-05-16 07:17:37]

lgtm

[shend, 2017-05-16 22:20:13]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-16 22:22:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:15:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-05-17 01:16:39]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 01:17:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:12:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:12:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-05-17 08:16:25]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 08:17:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 09:59:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 09:59:44]

Dry run: This issue passed the CQ dry run.

[shend, 2017-05-17 11:45:35]

The CQ bit was checked by shend@chromium.org

[commit-bot: I haz the power, 2017-05-17 11:45:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 11:50:20]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495021535310400, "parent_rev":
"3283d323c689285398d1ab564258bdb6567fd673", "commit_rev":
"ae9de50e595b29c947d00c8f652e8ac3ab41f768"}

[commit-bot: I haz the power, 2017-05-17 11:50:38]

Description was changed from

==========
Move RareInheritedData (Quotes|Shadow)DataEquivalent to ComputedStyle.

Currently, RareInheritedData has two helper functions:
QuotesDataEquivalent and ShadowDataEquivalent. When we generate
RareInheritedData, these helpers will no longer exist, so we need
to move them to CopmutedStyle.

This patch moves RareInheritedData::QuotesDataEquivalent and
RareInheritedData::ShadowDataEquivalent to ComputedStyle. It also
renames ShadowDataEquivalent to TextShadowDataEquivalent since it is
comparing text-shadow.

BUG=628043
==========

to

==========
Move RareInheritedData (Quotes|Shadow)DataEquivalent to ComputedStyle.

Currently, RareInheritedData has two helper functions:
QuotesDataEquivalent and ShadowDataEquivalent. When we generate
RareInheritedData, these helpers will no longer exist, so we need
to move them to CopmutedStyle.

This patch moves RareInheritedData::QuotesDataEquivalent and
RareInheritedData::ShadowDataEquivalent to ComputedStyle. It also
renames ShadowDataEquivalent to TextShadowDataEquivalent since it is
comparing text-shadow.

BUG=628043

Review-Url: https://codereview.chromium.org/2884153002
Cr-Commit-Position: refs/heads/master@{#472425}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae9de50e595b29c947d00c8f652e...
==========

[commit-bot: I haz the power, 2017-05-17 11:50:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae9de50e595b29c947d00c8f652e...