Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2882373002: Rename StyleRareInheritedData::indent_ to text_indent_. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename StyleRareInheritedData::indent_ to text_indent_. This patch renames StyleRareInheritedData::indent_ to text_indent_ to match the name of the CSS property that it represents. Link to text-indent spec: https://drafts.csswg.org/css-text-3/#text-indent BUG=628043 Review-Url: https://codereview.chromium.org/2882373002 Cr-Commit-Position: refs/heads/master@{#472027} Committed: https://chromium.googlesource.com/chromium/src/+/8a949f82ddc941825c2b3f6529e6ca95f7f7ed0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareInheritedData.cpp View 3 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
shend
Hi Suzy PTAL for OWNERS
3 years, 7 months ago (2017-05-16 02:36:44 UTC) #4
suzyh_UTC10 (ex-contributor)
lgtm with nit: Add relevant spec link to CL description
3 years, 7 months ago (2017-05-16 04:08:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882373002/1
3 years, 7 months ago (2017-05-16 05:59:38 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 06:04:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a949f82ddc941825c2b3f6529e6...

Powered by Google App Engine
This is Rietveld 408576698