Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2884103002: Merge to 3071 "[DevTools] Ensure that tab agent hosts get "page" type" (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge to 3071 "[DevTools] Ensure that tab agent hosts get "page" type" If we were to create DevToolsAgentHost for a WebContents before appending that to a tab strip, we wrongly assigned "other" type to it. This happens, for example, when devtools is discovering all agent hosts for newly created web contents. Regressed in crrev.com/7a0e557c4434a838ab29021ae039504fbab4f564 BUG=717003 Review-Url: https://codereview.chromium.org/2858763002 Cr-Commit-Position: refs/heads/master@{#468815} (cherry picked from commit 16fd697aa90b4a2dd30ff37ae51fd52a7c157a98) TBR=pfeldman Review-Url: https://codereview.chromium.org/2884103002 . Cr-Commit-Position: refs/branch-heads/3071@{#570} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d1cdb1eaec9319ade2c8bfe46b3b8b9ea60bd346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
dgozman
3 years, 7 months ago (2017-05-15 22:37:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1cdb1eaec9319ade2c8bfe46b3b8b9ea60bd346.

Powered by Google App Engine
This is Rietveld 408576698