Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2858763002: [DevTools] Ensure that tab agent hosts get "page" type (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Ensure that tab agent hosts get "page" type If we were to create DevToolsAgentHost for a WebContents before appending that to a tab strip, we wrongly assigned "other" type to it. This happens, for example, when devtools is discovering all agent hosts for newly created web contents. Regressed in crrev.com/7a0e557c4434a838ab29021ae039504fbab4f564 BUG=717003 Review-Url: https://codereview.chromium.org/2858763002 Cr-Commit-Position: refs/heads/master@{#468815} Committed: https://chromium.googlesource.com/chromium/src/+/16fd697aa90b4a2dd30ff37ae51fd52a7c157a98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-05-02 21:00:46 UTC) #3
pfeldman
lgtm
3 years, 7 months ago (2017-05-02 23:03:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858763002/1
3 years, 7 months ago (2017-05-02 23:18:59 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 23:34:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16fd697aa90b4a2dd30ff37ae51f...

Powered by Google App Engine
This is Rietveld 408576698