Chrome Cleaner: Update modal dialog's strings

Chrome Cleaner: Update modal dialog's strings

Also made the source files Windows-only since the dialog will only be available on Windows and will eventually need to call services that are available on Windows only.

BUG=690020
Review-Url: https://codereview.chromium.org/2883673002
Cr-Commit-Position: refs/heads/master@{#471821}
Committed: https://chromium.googlesource.com/chromium/src/+/026d7180490c04de18c2327e1d5e1912f4177042

[alito, 2017-05-12 21:41:44]

alito@chromium.org changed reviewers:
+ csharp@chromium.org, ftirelo@chromium.org

[alito, 2017-05-12 21:41:46]

Updating the strings for the Chrome Cleaner dialog. PTAL!

[ftirelo, 2017-05-12 23:39:59]

lgtm

[alito, 2017-05-12 23:52:30]

Description was changed from

==========
Chrome Cleaner: Update modal dialog's strings

BUG=690020
==========

to

==========
Chrome Cleaner: Update modal dialog's strings

Also made the source files Windows-only since the dialog will only be available
on Windows and will eventually need to call services that are available on
Windows only.

BUG=690020
==========

[alito, 2017-05-12 23:53:22]

alito@chromium.org changed reviewers:
+ sky@chromium.org

[alito, 2017-05-12 23:53:23]

Adding sky@ for OWNER's approval for c/b/ui/views.

[sky, 2017-05-14 16:15:31]

LGTM

https://codereview.chromium.org/2883673002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2883673002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:2433:
"../browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc",
You should be able to list this with all files and because it ends in _win it'll
only be compiled on windows.

[csharp, 2017-05-15 13:33:49]

lgtm

[alito, 2017-05-15 15:07:26]

https://codereview.chromium.org/2883673002/diff/1/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2883673002/diff/1/chrome/test/BUILD.gn#newcod...
chrome/test/BUILD.gn:2433:
"../browser/ui/views/chrome_cleaner_dialog_browsertest_win.cc",
On 2017/05/14 16:15:31, sky wrote:
> You should be able to list this with all files and because it ends in _win
it'll
> only be compiled on windows.

Done.

[alito, 2017-05-15 15:07:37]

The CQ bit was checked by alito@chromium.org

[alito, 2017-05-15 15:07:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
ftirelo@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2883673002/#ps20001
(title: "Moved to the non-android section in BUILD file.")

[commit-bot: I haz the power, 2017-05-15 15:08:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 17:50:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494860857594730,
"parent_rev": "40f898c48cccf321bc48fe2f58b03a84b167a4e5", "commit_rev":
"026d7180490c04de18c2327e1d5e1912f4177042"}

[commit-bot: I haz the power, 2017-05-15 17:50:54]

Description was changed from

==========
Chrome Cleaner: Update modal dialog's strings

Also made the source files Windows-only since the dialog will only be available
on Windows and will eventually need to call services that are available on
Windows only.

BUG=690020
==========

to

==========
Chrome Cleaner: Update modal dialog's strings

Also made the source files Windows-only since the dialog will only be available
on Windows and will eventually need to call services that are available on
Windows only.

BUG=690020

Review-Url: https://codereview.chromium.org/2883673002
Cr-Commit-Position: refs/heads/master@{#471821}
Committed:
https://chromium.googlesource.com/chromium/src/+/026d7180490c04de18c2327e1d5e...
==========

[commit-bot: I haz the power, 2017-05-15 17:50:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/026d7180490c04de18c2327e1d5e...