Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.cc

Issue 2883673002: Chrome Cleaner: Update modal dialog's strings (Closed)
Patch Set: Moved to the non-android section in BUILD file. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.cc
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller.cc b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.cc
similarity index 51%
rename from chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller.cc
rename to chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.cc
index a5e6ab24412ebeaf9fa832c0ba372658cc48fe41..b2bc68bd4f37a8b1abd9938373c7e000306c7cec 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller.cc
+++ b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.cc
@@ -2,44 +2,34 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller.h"
+#include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h"
-#include "base/strings/utf_string_conversions.h"
+#include "chrome/grit/chromium_strings.h"
+#include "chrome/grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
namespace safe_browsing {
-namespace {
-
-// Some dummy strings to be displayed in the Cleaner dialog while iterating on
-// the dialog's UX design and work on the Chrome<->Cleaner IPC is ongoing.
-constexpr char kWindowTitle[] = "Clean up your computer?";
-constexpr char kMainText[] =
- "Chrome found software that harms your browsing experience. Remove related "
- "files from your computer and restore browser settings, including your "
- "search engine and home page.";
-constexpr char kAcceptButtonLabel[] = "Cleanup";
-constexpr char kAdvancedButtonLabel[] = "Advanced";
-
-} // namespace
-
ChromeCleanerDialogController::ChromeCleanerDialogController() {}
ChromeCleanerDialogController::~ChromeCleanerDialogController() = default;
base::string16 ChromeCleanerDialogController::GetWindowTitle() const {
- return base::UTF8ToUTF16(kWindowTitle);
+ return l10n_util::GetStringUTF16(IDS_CHROME_CLEANUP_PROMPT_TITLE);
}
base::string16 ChromeCleanerDialogController::GetMainText() const {
- return base::UTF8ToUTF16(kMainText);
+ return l10n_util::GetStringUTF16(IDS_CHROME_CLEANUP_PROMPT_EXPLANATION);
}
base::string16 ChromeCleanerDialogController::GetAcceptButtonLabel() const {
- return base::UTF8ToUTF16(kAcceptButtonLabel);
+ return l10n_util::GetStringUTF16(
+ IDS_CHROME_CLEANUP_PROMPT_REMOVE_BUTTON_LABEL);
}
-base::string16 ChromeCleanerDialogController::GetAdvancedButtonLabel() const {
- return base::UTF8ToUTF16(kAdvancedButtonLabel);
+base::string16 ChromeCleanerDialogController::GetDetailsButtonLabel() const {
+ return l10n_util::GetStringUTF16(
+ IDS_CHROME_CLEANUP_PROMPT_DETAILS_BUTTON_LABEL);
}
void ChromeCleanerDialogController::DialogShown() {}
@@ -56,7 +46,7 @@ void ChromeCleanerDialogController::Close() {
OnInteractionDone();
}
-void ChromeCleanerDialogController::AdvancedButtonClicked() {
+void ChromeCleanerDialogController::DetailsButtonClicked() {
OnInteractionDone();
}
« no previous file with comments | « chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h ('k') | chrome/browser/ui/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698