Enable store tombstones for swarming bots.

Enable store tombstones for swarming bots.

Enable tombstones for swarming bots. Previously if a test case is
crashed on swarming bots, no tombstones will be resolved, and even if
they are attempted to be resolved, they will fail because of the lack of
tool chains.

In this cl, we are enabling tombstones for swarming bots and we are also
adding tool chains to the dependency.

BUG=631213
Review-Url: https://codereview.chromium.org/2883633003
Cr-Commit-Position: refs/heads/master@{#472615}
Committed: https://chromium.googlesource.com/chromium/src/+/fc66094f89df0ecca2a3378296304a9c7e66bbff

[BigBossZhiling, 2017-05-16 19:24:15]

hzl@google.com changed reviewers:
+ jbudorick@chromium.org

[BigBossZhiling, 2017-05-16 19:24:16]

The trybot of patch 17 shows that toolchains have been successfully retrieved
and tombstones are successfully resolved and presented.

[jbudorick, 2017-05-16 19:48:26]

https://codereview.chromium.org/2883633003/diff/340001/build/secondary/third_...
File build/secondary/third_party/android_platform/development/scripts/BUILD.gn
(right):

https://codereview.chromium.org/2883633003/diff/340001/build/secondary/third_...
build/secondary/third_party/android_platform/development/scripts/BUILD.gn:14:
data +=
["//third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-addr2line",
I *think* you could do something like

  if (target_cpu == "arm") {
    data += [
        "${android_toolchain_root}/bin/arm-linux-androideabi-addr2line"
        ...
    ]
  } ...

We define the toolchain root here:
https://codesearch.chromium.org/chromium/src/build/config/android/config.gni?...

[BigBossZhiling, 2017-05-17 05:39:13]

Used environmental variables instead of hard coded directory path.

[jbudorick, 2017-05-17 16:30:40]

This looks fine, but before we land it, I think we need to address packed
relocation handling in the tombstones.

https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
File build/secondary/third_party/android_platform/development/scripts/BUILD.gn
(right):

https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
build/secondary/third_party/android_platform/development/scripts/BUILD.gn:14:
import("//build/config/android/config.gni")
nit: move this outside of the stack_py definition

https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
build/secondary/third_party/android_platform/development/scripts/BUILD.gn:15:
data += ["${android_tool_prefix}addr2line",
Nice find! This is much better than my suggestion :)

https://codereview.chromium.org/2883633003/diff/400001/chrome/android/javates...
File chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java
(right):

https://codereview.chromium.org/2883633003/diff/400001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java:17:
//import org.chromium.base.test.util.DisabledTest;
nit: back out these changes, obv

[jbudorick, 2017-05-17 17:43:10]

On 2017/05/17 16:30:40, jbudorick wrote:
> This looks fine, but before we land it, I think we need to address packed
> relocation handling in the tombstones.

actually, I'm ok w/ this landing before we fix packed relocations, though we
should mention that in the bug.

lgtm w/ nits

> 
>
https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
> File build/secondary/third_party/android_platform/development/scripts/BUILD.gn
> (right):
> 
>
https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
> build/secondary/third_party/android_platform/development/scripts/BUILD.gn:14:
> import("//build/config/android/config.gni")
> nit: move this outside of the stack_py definition
> 
>
https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
> build/secondary/third_party/android_platform/development/scripts/BUILD.gn:15:
> data += ["${android_tool_prefix}addr2line",
> Nice find! This is much better than my suggestion :)
> 
>
https://codereview.chromium.org/2883633003/diff/400001/chrome/android/javates...
> File chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java
> (right):
> 
>
https://codereview.chromium.org/2883633003/diff/400001/chrome/android/javates...
> chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java:17:
> //import org.chromium.base.test.util.DisabledTest;
> nit: back out these changes, obv

[BigBossZhiling, 2017-05-17 21:28:13]

https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
File build/secondary/third_party/android_platform/development/scripts/BUILD.gn
(right):

https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
build/secondary/third_party/android_platform/development/scripts/BUILD.gn:14:
import("//build/config/android/config.gni")
On 2017/05/17 16:30:40, jbudorick wrote:
> nit: move this outside of the stack_py definition

Done.

https://codereview.chromium.org/2883633003/diff/400001/build/secondary/third_...
build/secondary/third_party/android_platform/development/scripts/BUILD.gn:15:
data += ["${android_tool_prefix}addr2line",
On 2017/05/17 16:30:40, jbudorick wrote:
> Nice find! This is much better than my suggestion :)

Acknowledged.

https://codereview.chromium.org/2883633003/diff/400001/chrome/android/javates...
File chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java
(right):

https://codereview.chromium.org/2883633003/diff/400001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java:17:
//import org.chromium.base.test.util.DisabledTest;
On 2017/05/17 16:30:40, jbudorick wrote:
> nit: back out these changes, obv

Done.

[BigBossZhiling, 2017-05-17 21:28:18]

The CQ bit was checked by hzl@google.com

[BigBossZhiling, 2017-05-17 21:28:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2883633003/#ps420001
(title: "fixes")

[commit-bot: I haz the power, 2017-05-17 21:30:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 23:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 23:13:29]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[BigBossZhiling, 2017-05-17 23:14:23]

The CQ bit was checked by hzl@google.com

[commit-bot: I haz the power, 2017-05-17 23:15:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 00:50:54]

CQ is committing da patch.

Bot data: {"patchset_id": 420001, "attempt_start_ts": 1495062863186830,
"parent_rev": "a2bc3db508d2a5bc022041c4de0b801384a2b17c", "commit_rev":
"fc66094f89df0ecca2a3378296304a9c7e66bbff"}

[commit-bot: I haz the power, 2017-05-18 00:51:05]

Description was changed from

==========
Enable store tombstones for swarming bots.

Enable tombstones for swarming bots. Previously if a test case is
crashed on swarming bots, no tombstones will be resolved, and even if
they are attempted to be resolved, they will fail because of the lack of
tool chains.

In this cl, we are enabling tombstones for swarming bots and we are also
adding tool chains to the dependency.

BUG=631213
==========

to

==========
Enable store tombstones for swarming bots.

Enable tombstones for swarming bots. Previously if a test case is
crashed on swarming bots, no tombstones will be resolved, and even if
they are attempted to be resolved, they will fail because of the lack of
tool chains.

In this cl, we are enabling tombstones for swarming bots and we are also
adding tool chains to the dependency.

BUG=631213

Review-Url: https://codereview.chromium.org/2883633003
Cr-Commit-Position: refs/heads/master@{#472615}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc66094f89df0ecca2a337829630...
==========

[commit-bot: I haz the power, 2017-05-18 00:51:06]

Committed patchset #22 (id:420001) as
https://chromium.googlesource.com/chromium/src/+/fc66094f89df0ecca2a337829630...