build/secondary/third_party/android_platform/development/scripts/BUILD.gn - Issue 2883633003: Enable store tombstones for swarming bots.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/secondary/third_party/android_platform/development/scripts/BUILD.gn

Issue 2883633003: Enable store tombstones for swarming bots. (Closed)

Patch Set: fixes Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java » ('j') | chrome/android/javatests/src/org/chromium/chrome/browser/CrashTest.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2017 The Chromium Authors. All rights reserved.	1 # Copyright 2017 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 group("stack_py") {	5 group("stack_py") {

6 _py_files = read_file(	6 _py_files = read_file(

7 "//build/secondary/third_party/android_platform/development/scripts/st ack.pydeps",	7 "//build/secondary/third_party/android_platform/development/scripts/st ack.pydeps",

8 "list lines")	8 "list lines")

9	9

10 set_sources_assignment_filter([ "#*" ])	10 set_sources_assignment_filter([ "#*" ])

11 sources = _py_files	11 sources = _py_files

12 data = sources	12 data = sources

	13

	14 import("//build/config/android/config.gni")
	jbudorick 2017/05/17 16:30:40 nit: move this outside of the stack_py definition nit: move this outside of the stack_py definition BigBossZhiling 2017/05/17 21:28:12 Done. Show quoted text On 2017/05/17 16:30:40, jbudorick wrote: > nit: move this outside of the stack_py definition Done.
	15 data += ["${android_tool_prefix}addr2line",
	jbudorick 2017/05/17 16:30:40 Nice find! This is much better than my suggestion Nice find! This is much better than my suggestion :) BigBossZhiling 2017/05/17 21:28:12 Acknowledged. Show quoted text On 2017/05/17 16:30:40, jbudorick wrote: > Nice find! This is much better than my suggestion :) Acknowledged.
	16 "${android_tool_prefix}objdump",

	17 "${android_tool_prefix}c++filt"]

13 }	18 }

OLD	NEW