Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2883623004: fix KeyEvent and KeyboardEvent (Closed)

Created:
3 years, 7 months ago by sra1
Modified:
3 years, 7 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix KeyEvent and KeyboardEvent Some keyboard specific properties moved in the IDL from UIEvent to KeyboardEvent. We has done work to hide them on UIEvent; this needed to be updated. TBR=terry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/01ba5f8d7406a90885d0acf4d15793348f79e106

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -42 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 14 chunks +26 lines, -12 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +19 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +1 line, -8 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +4 lines, -5 lines 0 comments Download
M tools/dom/src/KeyboardEventStream.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 6 chunks +6 lines, -7 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 2 chunks +4 lines, -4 lines 1 comment Download
M tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
3 years, 7 months ago (2017-05-12 23:01:02 UTC) #3
sra1
Committed patchset #1 (id:1) manually as 01ba5f8d7406a90885d0acf4d15793348f79e106 (presubmit successful).
3 years, 7 months ago (2017-05-12 23:03:16 UTC) #5
Jacob
3 years, 7 months ago (2017-05-12 23:28:19 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2883623004/diff/1/tools/dom/templates/html/da...
File tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate (right):

https://codereview.chromium.org/2883623004/diff/1/tools/dom/templates/html/da...
tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate:29: int
location: 1, bool ctrlKey: false,
We shouldn't be making breaking changes to the Dart API for common classes
unless we can avoid it.
I would change this name back to keyLocation even though location is indeed a
better variable name.
You could always add
location as well as keyLocation.

Powered by Google App Engine
This is Rietveld 408576698