Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/dom/src/dart2js_KeyEvent.dart

Issue 2883623004: fix KeyEvent and KeyboardEvent (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/src/dart2js_KeyEvent.dart
diff --git a/tools/dom/src/dart2js_KeyEvent.dart b/tools/dom/src/dart2js_KeyEvent.dart
index 0d4a7539ebc6302fdc9e27803f22ffa32e622afc..b9c627ba76c23296e3581c697f6e4c58c3d40d7a 100644
--- a/tools/dom/src/dart2js_KeyEvent.dart
+++ b/tools/dom/src/dart2js_KeyEvent.dart
@@ -93,7 +93,7 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
bool cancelable: true,
int keyCode: 0,
int charCode: 0,
- int keyLocation: 1,
+ int location: 1,
bool ctrlKey: false,
bool altKey: false,
bool shiftKey: false,
@@ -119,7 +119,7 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
JS('void', '#.which = #', eventObj, keyCode);
JS('void', '#.charCode = #', eventObj, charCode);
- JS('void', '#.keyLocation = #', eventObj, keyLocation);
+ JS('void', '#.location = #', eventObj, location);
JS('void', '#.ctrlKey = #', eventObj, ctrlKey);
JS('void', '#.altKey = #', eventObj, altKey);
JS('void', '#.shiftKey = #', eventObj, shiftKey);
@@ -155,7 +155,7 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
var keyIdentifier = _convertToHexString(charCode, keyCode);
eventObj._initKeyboardEvent(type, canBubble, cancelable, view,
- keyIdentifier, keyLocation, ctrlKey, altKey, shiftKey, metaKey);
+ keyIdentifier, location, ctrlKey, altKey, shiftKey, metaKey);
JS('void', '#.keyCodeVal = #', eventObj, keyCode);
JS('void', '#.charCodeVal = #', eventObj, charCode);
}
@@ -213,7 +213,7 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
* KeyLocation.STANDARD, KeyLocation.RIGHT, KeyLocation.LEFT,
* KeyLocation.NUMPAD, KeyLocation.MOBILE, KeyLocation.JOYSTICK).
*/
- int get keyLocation => _parent.keyLocation;
+ int get location => _parent.location;
/** True if the Meta (or Mac command) key is pressed during this event. */
bool get metaKey => _parent.metaKey;
/** True if the shift key was pressed during this event. */
@@ -240,7 +240,7 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
bool cancelable,
Window view,
String keyIdentifier,
- int keyLocation,
+ int location,
bool ctrlKey,
bool altKey,
bool shiftKey,
@@ -251,8 +251,7 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
@Experimental() // untriaged
bool getModifierState(String keyArgument) => throw new UnimplementedError();
- @Experimental() // untriaged
- int get location => throw new UnimplementedError();
+
@Experimental() // untriaged
bool get repeat => throw new UnimplementedError();
dynamic get _get_view => throw new UnimplementedError();

Powered by Google App Engine
This is Rietveld 408576698