Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 2883623004: fix KeyEvent and KeyboardEvent (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 6bcdb02dd9399a1715ebce0b3fb99c8c7c46d488..fc6b7aaa14683ea8ecd512389c1f0010452becf8 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -24964,7 +24964,7 @@ class KeyboardEvent extends UIEvent {
{Window view,
bool canBubble: true,
bool cancelable: true,
- int keyLocation: 1,
+ int location: 1,
bool ctrlKey: false,
bool altKey: false,
bool shiftKey: false,
@@ -24973,7 +24973,7 @@ class KeyboardEvent extends UIEvent {
view = window;
}
final e = document._createEvent("KeyboardEvent");
- e._initKeyboardEvent(type, canBubble, cancelable, view, "", keyLocation,
+ e._initKeyboardEvent(type, canBubble, cancelable, view, "", location,
ctrlKey, altKey, shiftKey, metaKey);
return e;
}
@@ -25028,6 +25028,12 @@ class KeyboardEvent extends UIEvent {
@DocsEditable()
bool get altKey => _blink.BlinkKeyboardEvent.instance.altKey_Getter_(this);
+ @DomName('KeyboardEvent.charCode')
+ @DocsEditable()
+ @Experimental() // untriaged
+ int get _charCode =>
+ _blink.BlinkKeyboardEvent.instance.charCode_Getter_(this);
+
@DomName('KeyboardEvent.code')
@DocsEditable()
@Experimental() // untriaged
@@ -25042,6 +25048,11 @@ class KeyboardEvent extends UIEvent {
@Experimental() // untriaged
String get key => _blink.BlinkKeyboardEvent.instance.key_Getter_(this);
+ @DomName('KeyboardEvent.keyCode')
+ @DocsEditable()
+ @Experimental() // untriaged
+ int get _keyCode => _blink.BlinkKeyboardEvent.instance.keyCode_Getter_(this);
+
@DomName('KeyboardEvent.keyIdentifier')
@DocsEditable()
@Experimental() // nonstandard
@@ -25067,6 +25078,11 @@ class KeyboardEvent extends UIEvent {
bool get shiftKey =>
_blink.BlinkKeyboardEvent.instance.shiftKey_Getter_(this);
+ @DomName('KeyboardEvent.which')
+ @DocsEditable()
+ @Experimental() // untriaged
+ int get _which => _blink.BlinkKeyboardEvent.instance.which_Getter_(this);
+
@DomName('KeyboardEvent.getModifierState')
@DocsEditable()
@Experimental() // untriaged
@@ -50773,7 +50789,7 @@ class _KeyboardEventHandler extends EventStreamProvider<KeyEvent> {
* keypress events.
*/
int _findCharCodeKeyDown(KeyboardEvent event) {
- if (event.keyLocation == 3) {
+ if (event.location == 3) {
// Numpad keys.
switch (event.keyCode) {
case KeyCode.NUM_ZERO:

Powered by Google App Engine
This is Rietveld 408576698