Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2883603002: Use the new tracing based measurement for blink_perf.paint (Closed)

Created:
3 years, 7 months ago by Xianzhu
Modified:
3 years, 7 months ago
Reviewers:
nednguyen, pdr.
CC:
chromium-reviews, blink-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the new tracing based measurement for blink_perf.paint BUG=717014 Review-Url: https://codereview.chromium.org/2883603002 Cr-Commit-Position: refs/heads/master@{#471570} Committed: https://chromium.googlesource.com/chromium/src/+/f47e5b3d95cbbd0443f5c5a85ef476f2cefdfbb9

Patch Set 1 #

Total comments: 1

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -62 lines) Patch
M third_party/WebKit/PerformanceTests/Paint/appending-text.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/color-changes.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/complex-content-slow-scroll.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/containment-resize.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/fixed-and-many-layers-scroll.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-background-change-with-invisible-collapsed-borders.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-background-change-with-visible-collapsed-borders.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-background-change-with-zero-width-collapsed-borders.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-collapsed-border-change.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-collapsed-border-change-with-backgrounds.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-collapsed-border-change-with-text.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-repaint.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/paint-offset-changes.html View 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/PerformanceTests/Paint/resources/paint.js View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/transform-changes.html View 2 chunks +2 lines, -1 line 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 4 chunks +2 lines, -48 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Xianzhu
3 years, 7 months ago (2017-05-12 20:29:05 UTC) #2
nednguyen
https://codereview.chromium.org/2883603002/diff/1/tools/perf/benchmarks/blink_perf.py File tools/perf/benchmarks/blink_perf.py (right): https://codereview.chromium.org/2883603002/diff/1/tools/perf/benchmarks/blink_perf.py#newcode343 tools/perf/benchmarks/blink_perf.py:343: 'FrameView::prePaint' : 'prePaint', Besides the data continuity problem, do ...
3 years, 7 months ago (2017-05-12 21:45:30 UTC) #5
nednguyen
On 2017/05/12 21:45:30, nednguyen wrote: > https://codereview.chromium.org/2883603002/diff/1/tools/perf/benchmarks/blink_perf.py > File tools/perf/benchmarks/blink_perf.py (right): > > https://codereview.chromium.org/2883603002/diff/1/tools/perf/benchmarks/blink_perf.py#newcode343 > ...
3 years, 7 months ago (2017-05-12 21:46:06 UTC) #6
Xianzhu
On 2017/05/12 21:46:06, nednguyen wrote: > On 2017/05/12 21:45:30, nednguyen wrote: > > > https://codereview.chromium.org/2883603002/diff/1/tools/perf/benchmarks/blink_perf.py ...
3 years, 7 months ago (2017-05-12 22:14:16 UTC) #9
nednguyen
lgtm
3 years, 7 months ago (2017-05-12 23:03:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883603002/20001
3 years, 7 months ago (2017-05-12 23:09:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/453624)
3 years, 7 months ago (2017-05-13 00:09:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883603002/20001
3 years, 7 months ago (2017-05-13 00:17:56 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 05:54:07 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f47e5b3d95cbbd0443f5c5a85ef4...

Powered by Google App Engine
This is Rietveld 408576698