Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2883413002: [Offline pages] Reporting completed attempt when Chrome is killed (Closed)

Created:
3 years, 7 months ago by fgorski
Modified:
3 years, 7 months ago
Reviewers:
Pete Williamson
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Reporting completed attempt when Chrome is killed * Adds new Offliner::RequestStatus::BROWSER_KILLED. * Reports UMA for requests updated in reconcile task with the status above. BUG=705115 R=petewil@chromium.org Review-Url: https://codereview.chromium.org/2883413002 Cr-Commit-Position: refs/heads/master@{#472233} Committed: https://chromium.googlesource.com/chromium/src/+/cb86cbdb812080c795bef2b2b21089d30c1797fc

Patch Set 1 #

Patch Set 2 : Udpating the histogram enum definition: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M components/offline_pages/core/background/offliner.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M components/offline_pages/core/background/request_coordinator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fgorski
PTAL (This appears to be simpler than expected).
3 years, 7 months ago (2017-05-16 19:59:04 UTC) #4
Pete Williamson
lgtm
3 years, 7 months ago (2017-05-16 20:32:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2883413002/20001
3 years, 7 months ago (2017-05-16 20:37:06 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 22:45:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cb86cbdb812080c795bef2b2b210...

Powered by Google App Engine
This is Rietveld 408576698