Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: components/offline_pages/core/background/offliner.h

Issue 2883413002: [Offline pages] Reporting completed attempt when Chrome is killed (Closed)
Patch Set: Udpating the histogram enum definition: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/core/background/request_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/core/background/offliner.h
diff --git a/components/offline_pages/core/background/offliner.h b/components/offline_pages/core/background/offliner.h
index aae5fd9c780027f83747b3abce68c566d5c2353c..c24aa46300745edaca26dcec929a82796cc605e7 100644
--- a/components/offline_pages/core/background/offliner.h
+++ b/components/offline_pages/core/background/offliner.h
@@ -57,6 +57,15 @@ class Offliner {
BACKGROUND_SCHEDULER_CANCELED = 14,
// We saved a snapshot on the last retry, after timeout.
SAVED_ON_LAST_RETRY = 15,
+ // Indicates that attempt failed due to browser being killed.
+ // There are 3 ways that might happen:
+ // * System was running out of memory, while browser was running in the
+ // background.
+ // * User swiped away the browser as it was offlining content.
+ // * Offliner crashed.
+ // We detect the situation in ReconcileTask after starting
+ // RequestCoordinator.
+ BROWSER_KILLED = 16,
// NOTE: insert new values above this line and update histogram enum too.
STATUS_COUNT
};
« no previous file with comments | « no previous file | components/offline_pages/core/background/request_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698