third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h - Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)

Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/LocalFrame.cpp ('K') | « third_party/WebKit/Source/core/page/PrintContext.cpp ('k') | third_party/WebKit/Source/core/timing/PerformanceTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h b/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h

index 352c59683aa0db2f0503fec8128d86e178f46c52..8cedc5ed24a221a65f26361bee6f237aa228bb5f 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollStateCallback.h

@@ -25,7 +25,7 @@ class ScrollStateCallback

virtual void handleEvent(ScrollState*) = 0;

void SetNativeScrollBehavior(WebNativeScrollBehavior native_scroll_behavior) {

- ASSERT(static_cast<int>(native_scroll_behavior) < 3);

+ DCHECK_LT(static_cast<int>(native_scroll_behavior), 3);

native_scroll_behavior_ = native_scroll_behavior;

}