Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceTiming.cpp

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)
Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp b/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
index cb842a167927814870df38fcbc48bb216accace7..a7a7d516512a52c1d7765b88fae8923a3b0678fc 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
@@ -49,7 +49,7 @@
namespace blink {
static unsigned long long ToIntegerMilliseconds(double seconds) {
- ASSERT(seconds >= 0);
+ DCHECK_GE(seconds, 0);
double clamped_seconds = PerformanceBase::ClampTimeResolution(seconds);
return static_cast<unsigned long long>(clamped_seconds * 1000.0);
}
@@ -518,7 +518,7 @@ ScriptValue PerformanceTiming::toJSONForBinding(
unsigned long long PerformanceTiming::MonotonicTimeToIntegerMilliseconds(
double monotonic_seconds) const {
- ASSERT(monotonic_seconds >= 0);
+ DCHECK_GE(monotonic_seconds, 0);
const DocumentLoadTiming* timing = GetDocumentLoadTiming();
if (!timing)
return 0;

Powered by Google App Engine
This is Rietveld 408576698