third_party/WebKit/Source/core/frame/LocalFrame.cpp - Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrame.cpp

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)

Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/LocalFrame.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalFrame.cpp b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

index 584a14db80632efd22be44e70f77571375892400..404cbce7edeae5b552ab277f169a24e59853fa1c 100644

--- a/third_party/WebKit/Source/core/frame/LocalFrame.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalFrame.cpp

@@ -643,7 +643,8 @@ FloatSize LocalFrame::ResizePageRectsKeepingRatio(

return FloatSize();

if (ContentLayoutItem().Style()->IsHorizontalWritingMode()) {

- ASSERT(fabs(original_size.Width()) > std::numeric_limits<float>::epsilon());

+ DCHECK_GT(fabs(original_size.Width()),

+ std::numeric_limits<float>::epsilon());

float ratio = original_size.Height() / original_size.Width();

result_size.SetWidth(floorf(expected_size.Width()));

result_size.SetHeight(floorf(result_size.Width() * ratio));