third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl - Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)

Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

index 0d38a40944e76837d6492696ce6117d23bf5e910..bf79041f39c1827546478e6f4e99edea75b2d4a4 100644

--- a/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

@@ -41,7 +41,7 @@ void StyleBuilder::ApplyProperty(CSSPropertyID property,

{% endfor %}

{

CSSPropertyID resolvedProperty = CSSProperty::ResolveDirectionAwareProperty(property, state.Style()->Direction(), state.Style()->GetWritingMode());

- ASSERT(resolvedProperty != property);

+ DCHECK_NE(resolvedProperty, property);

ApplyProperty(resolvedProperty, state, value);

return;

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/clipboard/DataTransfer.cpp » ('j') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('J')