Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

Issue 2883353002: Replace ASSERT with DCHECK_LE/GE/GT/LT/NE as appropriate (Closed)
Patch Set: DCHECK in BluetoothCharacteristicProperties.cpp Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'macros.tmpl' import license %} 1 {% from 'macros.tmpl' import license %}
2 {{license()}} 2 {{license()}}
3 3
4 #include "core/css/resolver/StyleBuilder.h" 4 #include "core/css/resolver/StyleBuilder.h"
5 5
6 #include "StyleBuilderFunctions.h" 6 #include "StyleBuilderFunctions.h"
7 #include "core/css/CSSProperty.h" 7 #include "core/css/CSSProperty.h"
8 #include "core/css/resolver/StyleResolverState.h" 8 #include "core/css/resolver/StyleResolverState.h"
9 9
10 // FIXME: currently we're just generating a switch statement, but we should 10 // FIXME: currently we're just generating a switch statement, but we should
(...skipping 23 matching lines...) Expand all
34 {% endfor %} 34 {% endfor %}
35 case CSSPropertyVariable: 35 case CSSPropertyVariable:
36 ASSERT(!isInitial && !isInherit); 36 ASSERT(!isInitial && !isInherit);
37 StyleBuilderFunctions::applyValueCSSPropertyVariable(state, value); 37 StyleBuilderFunctions::applyValueCSSPropertyVariable(state, value);
38 return; 38 return;
39 {% for property_id, property in properties.items() if property.direction_awa re %} 39 {% for property_id, property in properties.items() if property.direction_awa re %}
40 case {{property_id}}: 40 case {{property_id}}:
41 {% endfor %} 41 {% endfor %}
42 { 42 {
43 CSSPropertyID resolvedProperty = CSSProperty::ResolveDirectionAwarePropert y(property, state.Style()->Direction(), state.Style()->GetWritingMode()); 43 CSSPropertyID resolvedProperty = CSSProperty::ResolveDirectionAwarePropert y(property, state.Style()->Direction(), state.Style()->GetWritingMode());
44 ASSERT(resolvedProperty != property); 44 DCHECK_NE(resolvedProperty, property);
45 ApplyProperty(resolvedProperty, state, value); 45 ApplyProperty(resolvedProperty, state, value);
46 return; 46 return;
47 } 47 }
48 {% for property_id, property in properties.items() if property.builder_skip %} 48 {% for property_id, property in properties.items() if property.builder_skip %}
49 case {{property_id}}: 49 case {{property_id}}:
50 {% endfor %} 50 {% endfor %}
51 return; 51 return;
52 default: 52 default:
53 NOTREACHED(); 53 NOTREACHED();
54 } 54 }
55 } 55 }
56 56
57 } // namespace blink 57 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698