Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2883273007: Revert of Ensure that the focus ring in the bookmarks bar does not paint outside the parent view. (Closed)

Created:
3 years, 7 months ago by timbrown_
Modified:
3 years, 7 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure that the focus ring in the bookmarks bar does not paint outside the parent view. (patchset #13 id:230001 of https://codereview.chromium.org/2813353002/ ) Reason for revert: Causes a UI regression on Linux where the overflow extension icons in the settings menu always render with a white background. See http://crbug.com/722965 Original issue's description: > Ensure that the focus ring in the bookmarks bar does not paint outside the parent view. > > The proposed fix is to notify the parent views when a child enables layering. The parent in > this case the ScrollView overrides the newly added notification OnChildLayerChanged() and enables > viewport layering. This ensures that the ring gets clipped. > > Longer term it seems like the focus ring should really be a property of the view and should not > be instantiated by different controls all over the place. > > That for a later patchset. > > BUG=665412, 656198 > TEST=Covered by test ViewObserverTest.ScrollViewChildAddLayerTest and ViewObserverTest.ChildViewLayerNotificationTest > > Review-Url: https://codereview.chromium.org/2813353002 > Cr-Commit-Position: refs/heads/master@{#465720} > Committed: https://chromium.googlesource.com/chromium/src/+/5c05d7143480feda606f6425f78f3b18598f9310 R=sky@chromium.org,ananta@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=665412, 656198, 722965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -217 lines) Patch
M ui/views/controls/scroll_view.h View 5 chunks +0 lines, -17 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 7 chunks +7 lines, -47 lines 0 comments Download
M ui/views/view.h View 3 chunks +3 lines, -26 lines 0 comments Download
M ui/views/view.cc View 3 chunks +28 lines, -50 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +0 lines, -77 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
timbrown_
3 years, 7 months ago (2017-05-17 22:34:13 UTC) #2
Created Revert of Ensure that the focus ring in the bookmarks bar does not paint
outside the parent view.

Powered by Google App Engine
This is Rietveld 408576698