DescriptionRevert of Ensure that the focus ring in the bookmarks bar does not paint outside the parent view. (patchset #13 id:230001 of https://codereview.chromium.org/2813353002/ )
Reason for revert:
Causes a UI regression on Linux where the overflow extension icons in the settings menu always render with a white background.
See http://crbug.com/722965
Original issue's description:
> Ensure that the focus ring in the bookmarks bar does not paint outside the parent view.
>
> The proposed fix is to notify the parent views when a child enables layering. The parent in
> this case the ScrollView overrides the newly added notification OnChildLayerChanged() and enables
> viewport layering. This ensures that the ring gets clipped.
>
> Longer term it seems like the focus ring should really be a property of the view and should not
> be instantiated by different controls all over the place.
>
> That for a later patchset.
>
> BUG=665412, 656198
> TEST=Covered by test ViewObserverTest.ScrollViewChildAddLayerTest and ViewObserverTest.ChildViewLayerNotificationTest
>
> Review-Url: https://codereview.chromium.org/2813353002
> Cr-Commit-Position: refs/heads/master@{#465720}
> Committed: https://chromium.googlesource.com/chromium/src/+/5c05d7143480feda606f6425f78f3b18598f9310
R=sky@chromium.org,ananta@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=665412, 656198, 722965
Patch Set 1 #
Messages
Total messages: 4 (3 generated)
|