Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: ui/views/controls/scroll_view.h

Issue 2883273007: Revert of Ensure that the focus ring in the bookmarks bar does not paint outside the parent view. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/controls/scroll_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/scroll_view.h
diff --git a/ui/views/controls/scroll_view.h b/ui/views/controls/scroll_view.h
index 0dea574a81bc1462a0f209c771f7514c570fc1f6..af9111a05cae1a2dd25daba64afe629560c7751e 100644
--- a/ui/views/controls/scroll_view.h
+++ b/ui/views/controls/scroll_view.h
@@ -17,8 +17,6 @@
}
namespace views {
-class ViewObserverTest;
-
namespace test {
class ScrollViewTestApi;
}
@@ -107,9 +105,6 @@
void OnGestureEvent(ui::GestureEvent* event) override;
const char* GetClassName() const override;
void OnNativeThemeChanged(const ui::NativeTheme* theme) override;
- void ViewHierarchyChanged(
- const ViewHierarchyChangedDetails& details) override;
- void OnChildLayerChanged(View* child) override;
// ScrollBarController overrides:
void ScrollToPosition(ScrollBar* source, int position) override;
@@ -123,7 +118,6 @@
private:
friend class test::ScrollViewTestApi;
- FRIEND_TEST_ALL_PREFIXES(ViewObserverTest, ScrollViewChildAddLayerTest);
class Viewport;
@@ -168,11 +162,6 @@
void AddBorder();
void UpdateBorder();
- // Enables view port layering if |child| or any of its descendants has a
- // layer. Returns true if yes. We short circuit the recursion if we enabled
- // layering.
- bool EnableLayeringRecursivelyForChild(View* child);
-
// The current contents and its viewport. |contents_| is contained in
// |contents_viewport_|.
View* contents_;
@@ -214,12 +203,6 @@
// Focus ring, if one is installed.
View* focus_ring_ = nullptr;
-
- // Set to true if we enabled layering for the viewport.
- bool viewport_layer_enabled_ = false;
-
- // Set to true if the scroll with layers feature is enabled.
- const bool scroll_with_layers_enabled_;
DISALLOW_COPY_AND_ASSIGN(ScrollView);
};
« no previous file with comments | « no previous file | ui/views/controls/scroll_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698