[LayoutNG] Implement inline margins for atomic inline boxes

[LayoutNG] Implement inline margins for atomic inline boxes

This patch implements inline margins for atomic inline boxes. Inline
margins for non-replaced inline boxes is not included and will be in
following patches.

Also changes not to generate OpenTag/CloseTag NGInlineItem for atomic
inline boxes. Atomic inlines use their margin boxes for inline layout
purposes, while non-replaced inline boxes has different characteristics.
Not generating OpenTag/CloseTag helps single code to handle both cases.

BUG=636993, 723135
Review-Url: https://codereview.chromium.org/2883213003
Cr-Commit-Position: refs/heads/master@{#472478}
Committed: https://chromium.googlesource.com/chromium/src/+/88768594c337f30f19c9b7ea2bd2d7d8820067a4

[kojii, 2017-05-16 08:53:55]

Description was changed from

==========
ngamargin

BUG=
==========

to

==========
ngamargin

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-05-17 05:13:29]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 05:14:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-05-17 05:21:47]

Description was changed from

==========
ngamargin

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Implement inline margins for atomic inline boxes

This patch implements inline margins for atomic inline boxes. Inline
margins for non-replaced inline boxes is not included and will be in
following patches.

Also changes not to generate OpenTag/CloseTag NGInlineItem for atomic
inline boxes. Atomic inlines use their margin boxes for inline layout
purposes, while non-replaced inline boxes has different characteristics.
Not generating OpenTag/CloseTag helps single code to handle both cases.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[commit-bot: I haz the power, 2017-05-17 06:31:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 06:31:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2017-05-17 07:55:13]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 07:55:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 09:57:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 09:57:03]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_layout_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does
not exist (misspelled?))

[kojii, 2017-05-17 09:59:50]

kojii@chromium.org changed reviewers:
+ eae@chromium.org

[kojii, 2017-05-17 09:59:51]

PTAL.

[eae, 2017-05-17 15:52:43]

LGTM!

[Gleb Lanbin, 2017-05-17 16:22:32]

Description was changed from

==========
[LayoutNG] Implement inline margins for atomic inline boxes

This patch implements inline margins for atomic inline boxes. Inline
margins for non-replaced inline boxes is not included and will be in
following patches.

Also changes not to generate OpenTag/CloseTag NGInlineItem for atomic
inline boxes. Atomic inlines use their margin boxes for inline layout
purposes, while non-replaced inline boxes has different characteristics.
Not generating OpenTag/CloseTag helps single code to handle both cases.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Implement inline margins for atomic inline boxes

This patch implements inline margins for atomic inline boxes. Inline
margins for non-replaced inline boxes is not included and will be in
following patches.

Also changes not to generate OpenTag/CloseTag NGInlineItem for atomic
inline boxes. Atomic inlines use their margin boxes for inline layout
purposes, while non-replaced inline boxes has different characteristics.
Not generating OpenTag/CloseTag helps single code to handle both cases.

BUG=636993,723135
==========

[Gleb Lanbin, 2017-05-17 16:22:36]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-05-17 16:23:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 16:39:11]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495038156804090,
"parent_rev": "e21aa45368ae7b37e47ce08d880062834d295693", "commit_rev":
"88768594c337f30f19c9b7ea2bd2d7d8820067a4"}

[commit-bot: I haz the power, 2017-05-17 16:39:22]

Description was changed from

==========
[LayoutNG] Implement inline margins for atomic inline boxes

This patch implements inline margins for atomic inline boxes. Inline
margins for non-replaced inline boxes is not included and will be in
following patches.

Also changes not to generate OpenTag/CloseTag NGInlineItem for atomic
inline boxes. Atomic inlines use their margin boxes for inline layout
purposes, while non-replaced inline boxes has different characteristics.
Not generating OpenTag/CloseTag helps single code to handle both cases.

BUG=636993,723135
==========

to

==========
[LayoutNG] Implement inline margins for atomic inline boxes

This patch implements inline margins for atomic inline boxes. Inline
margins for non-replaced inline boxes is not included and will be in
following patches.

Also changes not to generate OpenTag/CloseTag NGInlineItem for atomic
inline boxes. Atomic inlines use their margin boxes for inline layout
purposes, while non-replaced inline boxes has different characteristics.
Not generating OpenTag/CloseTag helps single code to handle both cases.

BUG=636993,723135

Review-Url: https://codereview.chromium.org/2883213003
Cr-Commit-Position: refs/heads/master@{#472478}
Committed:
https://chromium.googlesource.com/chromium/src/+/88768594c337f30f19c9b7ea2bd2...
==========

[commit-bot: I haz the power, 2017-05-17 16:39:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/88768594c337f30f19c9b7ea2bd2...