third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h - Issue 2883213003: [LayoutNG] Implement inline margins for atomic inline boxes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

Issue 2883213003: [LayoutNG] Implement inline margins for atomic inline boxes (Closed)

Patch Set: Fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.h ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

index c6f1db23d1499c1b90de27fc5970550fd5642029..7e9e601c788089fe22635ceeef3d4f8be44c3366 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

@@ -64,14 +64,16 @@ class CORE_EXPORT NGInlineLayoutAlgorithm final

const ComputedStyle& FirstLineStyle() const;

const ComputedStyle& LineStyle() const;

+ LayoutUnit LogicalLeftOffset() const;

void BidiReorder(NGInlineItemResults*);

bool PlaceItems(NGInlineItemResults*, RefPtr<NGInlineBreakToken>);

- LayoutUnit PlaceAtomicInline(const NGInlineItem&,

- NGInlineItemResult*,

- NGLineBoxFragmentBuilder*,

- NGInlineBoxState*,

- NGTextFragmentBuilder*);

+ NGInlineBoxState* PlaceAtomicInline(const NGInlineItem&,

+ NGInlineItemResult*,

+ LayoutUnit position,

+ NGLineBoxFragmentBuilder*,

+ NGTextFragmentBuilder*);

// Finds the next layout opportunity for the next text fragment.

void FindNextLayoutOpportunity();