Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2882983002: Avoid synchronous stylesheet update on html import loaded. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof, tfarina, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid synchronous stylesheet update on html import loaded. A use counter was updating the styleSheets list, which updated all of active style to figure out if an html import contains stylesheets. Instead, do a simpler walk of the stylesheet candidate nodes and return early if one of them has a sheet, or a sheet load is in progress. BUG=717506 Review-Url: https://codereview.chromium.org/2882983002 Cr-Commit-Position: refs/heads/master@{#472139} Committed: https://chromium.googlesource.com/chromium/src/+/9d4c419700c0edc7602c27d29a5b520f00bbe13a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/imports/HTMLImportChild.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/HTMLImportSheetsTest.cpp View 1 chunk +29 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (13 generated)
rune
ptal
3 years, 7 months ago (2017-05-15 14:21:19 UTC) #6
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-16 07:06:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882983002/1
3 years, 7 months ago (2017-05-16 08:01:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/438012)
3 years, 7 months ago (2017-05-16 08:09:21 UTC) #11
rune
jochen@ for web/
3 years, 7 months ago (2017-05-16 08:17:24 UTC) #13
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-16 11:16:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882983002/1
3 years, 7 months ago (2017-05-16 11:31:52 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/215949)
3 years, 7 months ago (2017-05-16 12:28:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882983002/1
3 years, 7 months ago (2017-05-16 13:10:04 UTC) #20
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 17:10:18 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9d4c419700c0edc7602c27d29a5b...

Powered by Google App Engine
This is Rietveld 408576698