Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2882943002: Removed mutable from PassRefPtr's raw pointer member. (Closed)

Created:
3 years, 7 months ago by Bugs Nash
Modified:
3 years, 7 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed mutable from PassRefPtr's raw pointer member. PassRefPtr is going to be replaced with RefPtr, and RefPtr's raw pointer member is not mutable. BUG=494719 Review-Url: https://codereview.chromium.org/2882943002 Cr-Commit-Position: refs/heads/master@{#471973} Committed: https://chromium.googlesource.com/chromium/src/+/c97b0b391db3ec87fbcf5c977aa3369e10f68ad7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/wtf/PassRefPtr.h View 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
Bugs Nash
3 years, 7 months ago (2017-05-15 04:53:33 UTC) #4
Yuta Kitamura
lgtm
3 years, 7 months ago (2017-05-15 04:54:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2882943002/1
3 years, 7 months ago (2017-05-16 01:13:52 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 01:35:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c97b0b391db3ec87fbcf5c977aa3...

Powered by Google App Engine
This is Rietveld 408576698