Made conversions from PassRefPtr to WebPrivatePtr move only.

Made conversions from PassRefPtr to WebPrivatePtr move only.

PassRefPtr objects being copied into WebPrivatePtr objects represent
places that would introduce ref churn in future patches where
PassRefPtr objects will be replaced with RefPtr objects. This patch
protects against that case.

This patch
- Changed PassRefPtr argument to WebPrivatePtr::Assign from a const ref
  to an rvalue.
- Changed WebPrivatePtr assignment operator and constructor taking a
  templated argument to use universal references and perfect forwarding
  to allow PassRefPtr rvalues to be passed through them.
- Added std::move wraps to PassRefPtr lvalues passed to WebPrivatePtr
  assignment operator and constructor.

BUG=494719
Review-Url: https://codereview.chromium.org/2879133002
Cr-Commit-Position: refs/heads/master@{#471686}
Committed: https://chromium.googlesource.com/chromium/src/+/400017516f70788e7297178a91155c3f501a8e41

[Bugs Nash, 2017-05-15 04:41:03]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 04:41:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-05-15 04:45:34]

bugsnash@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[Bugs Nash, 2017-05-15 04:45:35]

Note that this patch only allows PassRefPtr to be moved into WebPrivatePtr. This
means that in future RefPtr will also only be allowed to be moved into
WebPrivatePtr. At the moment this is the only functionality that is needed, but
WebPrivatePtr::Assign may be changed in future to accept both lvalue and rvalue
arguments if needed.

[Yuta Kitamura, 2017-05-15 04:47:23]

lgtm

[haraken, 2017-05-15 04:48:47]

LGTM

[commit-bot: I haz the power, 2017-05-15 06:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 06:40:23]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-05-15 06:57:16]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-05-15 06:57:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 07:02:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494831436343780, "parent_rev":
"6b5640c1733e8c715cd6939876663dbb6c44972c", "commit_rev":
"400017516f70788e7297178a91155c3f501a8e41"}

[commit-bot: I haz the power, 2017-05-15 07:02:44]

Description was changed from

==========
Made conversions from PassRefPtr to WebPrivatePtr move only.

PassRefPtr objects being copied into WebPrivatePtr objects represent
places that would introduce ref churn in future patches where
PassRefPtr objects will be replaced with RefPtr objects. This patch
protects against that case.

This patch
- Changed PassRefPtr argument to WebPrivatePtr::Assign from a const ref
  to an rvalue.
- Changed WebPrivatePtr assignment operator and constructor taking a
  templated argument to use universal references and perfect forwarding
  to allow PassRefPtr rvalues to be passed through them.
- Added std::move wraps to PassRefPtr lvalues passed to WebPrivatePtr
  assignment operator and constructor.

BUG=494719
==========

to

==========
Made conversions from PassRefPtr to WebPrivatePtr move only.

PassRefPtr objects being copied into WebPrivatePtr objects represent
places that would introduce ref churn in future patches where
PassRefPtr objects will be replaced with RefPtr objects. This patch
protects against that case.

This patch
- Changed PassRefPtr argument to WebPrivatePtr::Assign from a const ref
  to an rvalue.
- Changed WebPrivatePtr assignment operator and constructor taking a
  templated argument to use universal references and perfect forwarding
  to allow PassRefPtr rvalues to be passed through them.
- Added std::move wraps to PassRefPtr lvalues passed to WebPrivatePtr
  assignment operator and constructor.

BUG=494719

Review-Url: https://codereview.chromium.org/2879133002
Cr-Commit-Position: refs/heads/master@{#471686}
Committed:
https://chromium.googlesource.com/chromium/src/+/400017516f70788e7297178a9115...
==========

[commit-bot: I haz the power, 2017-05-15 07:02:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/400017516f70788e7297178a9115...