Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 288273004: A bunch of remaining parts of extension content verification (Reland) (Closed)

Created:
6 years, 7 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

A bunch of remaining parts of extension content verification (Reland) -The real guts of content_hash_fetcher.cc, which fetches the verified_contents.json file from the webstore if needed and also runs tasks to compute and cache the block-level hashes of all files in an extension. -The real guts of content_hash_reader.cc, which uses the work done by the content_hash_fetcher during validation of extension file content as it's read off of disk at time of use. -Code to avoid verifying transcoded files (images used in browser process, and message catalogs). -Don't allow downgrade of mode via kForceFieldTrials command line switch -Various bits of plumbing to support all of the above This is a re-land with fixes; original review was: https://codereview.chromium.org/289533003 BUG=369895, 373854 R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270937

Patch Set 1 : original content of first cl #289533003 #

Patch Set 2 : fix ASAN error, and also turn on actual enforcement #

Patch Set 3 : fix browser test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+821 lines, -17 lines) Patch
M chrome/browser/extensions/extension_system_impl.cc View 4 chunks +38 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +5 lines, -1 line 0 comments Download
A extensions/browser/computed_hashes.h View 1 chunk +64 lines, -0 lines 0 comments Download
A extensions/browser/computed_hashes.cc View 1 chunk +129 lines, -0 lines 0 comments Download
M extensions/browser/content_hash_fetcher.h View 3 chunks +15 lines, -0 lines 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 1 2 chunks +394 lines, -1 line 0 comments Download
M extensions/browser/content_hash_reader.h View 4 chunks +13 lines, -1 line 0 comments Download
M extensions/browser/content_hash_reader.cc View 1 2 chunks +72 lines, -4 lines 0 comments Download
M extensions/browser/content_verifier.cc View 4 chunks +46 lines, -4 lines 0 comments Download
M extensions/browser/content_verifier_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/content_verify_job.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/constants.h View 1 chunk +10 lines, -0 lines 0 comments Download
M extensions/common/constants.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/common/file_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/file_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
asargent_no_longer_on_chrome
Ken, can you take a look at the small diffs here from the first CL? ...
6 years, 7 months ago (2014-05-15 21:55:23 UTC) #1
Ken Rockot(use gerrit already)
On 2014/05/15 21:55:23, Antony Sargent wrote: > Ken, can you take a look at the ...
6 years, 7 months ago (2014-05-15 21:58:57 UTC) #2
asargent_no_longer_on_chrome
The CQ bit was checked by asargent@chromium.org
6 years, 7 months ago (2014-05-16 01:49:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/288273004/40001
6 years, 7 months ago (2014-05-16 01:49:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 05:12:21 UTC) #5
asargent_no_longer_on_chrome
6 years, 7 months ago (2014-05-16 05:22:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r270937 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698