A bunch of remaining parts of extension content verification (Reland)

chrome/browser/extensions/extension_system_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_system_impl.h"
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/memory/weak_ptr.h"
 #include "base/strings/string_tokenizer.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/extensions/blacklist.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/browser/extensions/error_console/error_console.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system_factory.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/extensions/extension_warning_badge_service.h"
 #include "chrome/browser/extensions/extension_warning_set.h"
 #include "chrome/browser/extensions/install_verifier.h"
 #include "chrome/browser/extensions/navigation_observer.h"
 #include "chrome/browser/extensions/standard_management_policy_provider.h"
 #include "chrome/browser/extensions/state_store.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
+#include "chrome/browser/extensions/updater/manifest_fetch_data.h"
 #include "chrome/browser/extensions/user_script_master.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
+#include "chrome/common/extensions/extension_file_util.h"
 #include "chrome/common/extensions/features/feature_channel.h"
 #include "chrome/common/extensions/manifest_url_handler.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/url_data_source.h"
 #include "extensions/browser/content_verifier.h"
 #include "extensions/browser/content_verifier_delegate.h"
 #include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_pref_store.h"
 #include "extensions/browser/extension_pref_value_map.h"
 #include "extensions/browser/extension_pref_value_map_factory.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/browser/lazy_background_task_queue.h"
 #include "extensions/browser/management_policy.h"
 #include "extensions/browser/process_manager.h"
 #include "extensions/browser/quota_service.h"
 #include "extensions/browser/runtime_data.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
+#include "net/base/escape.h"
 
 #if defined(ENABLE_NOTIFICATIONS)
 #include "chrome/browser/notifications/desktop_notification_service.h"
 #include "chrome/browser/notifications/desktop_notification_service_factory.h"
 #include "ui/message_center/notifier_settings.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/app_mode/app_mode_utils.h"
 #include "chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.h"
@@ skipping 78 matching lines @@
 namespace {
 
 class ContentVerifierDelegateImpl : public ContentVerifierDelegate {
  public:
   explicit ContentVerifierDelegateImpl(ExtensionService* service)
       : service_(service->AsWeakPtr()) {}
 
   virtual ~ContentVerifierDelegateImpl() {}
 
   virtual bool ShouldBeVerified(const Extension& extension) OVERRIDE {
-    return ((extension.is_extension() || extension.is_legacy_packaged_app()) &&
-            ManifestURL::UpdatesFromGallery(&extension) &&
-            Manifest::IsAutoUpdateableLocation(extension.location()));
+    if (!extension.is_extension() && !extension.is_legacy_packaged_app())
+      return false;
+    if (!Manifest::IsAutoUpdateableLocation(extension.location()))
+      return false;
+
+    if (!ManifestURL::UpdatesFromGallery(&extension)) {
+      // It's possible that the webstore update url was overridden for testing
+      // so also consider extensions with the default (production) update url
+      // to be from the store as well.
+      GURL default_webstore_url = extension_urls::GetDefaultWebstoreUpdateUrl();
+      if (ManifestURL::GetUpdateURL(&extension) != default_webstore_url)
+        return false;
+    }
+
+    return true;
   }
 
   virtual const ContentVerifierKey& PublicKey() OVERRIDE {
     static ContentVerifierKey key(
         extension_misc::kWebstoreSignaturesPublicKey,
         extension_misc::kWebstoreSignaturesPublicKeySize);
     return key;
   }
 
   virtual GURL GetSignatureFetchUrl(const std::string& extension_id,
                                     const base::Version& version) OVERRIDE {
-    return GURL();
+    // TODO(asargent) Factor out common code from the extension updater's
+    // ManifestFetchData class that can be shared for use here.
+    std::vector<std::string> parts;
+    parts.push_back("uc");
+    parts.push_back("installsource=signature");
+    parts.push_back("id=" + extension_id);
+    parts.push_back("v=" + version.GetString());
+    std::string x_value =
+        net::EscapeQueryParamValue(JoinString(parts, "&"), true);
+    std::string query = "response=redirect&x=" + x_value;
+
+    GURL base_url = extension_urls::GetWebstoreUpdateUrl();
+    GURL::Replacements replacements;
+    replacements.SetQuery(query.c_str(), url::Component(0, query.length()));
+    return base_url.ReplaceComponents(replacements);
+  }
+
+  virtual std::set<base::FilePath> GetBrowserImagePaths(
+      const extensions::Extension* extension) OVERRIDE {
+    return extension_file_util::GetBrowserImagePaths(extension);
   }
 
   virtual void VerifyFailed(const std::string& extension_id) OVERRIDE {
     if (service_)
       service_->DisableExtension(extension_id, Extension::DISABLE_CORRUPTED);
   }
 
  private:
   base::WeakPtr<ExtensionService> service_;
   DISALLOW_COPY_AND_ASSIGN(ContentVerifierDelegateImpl);
@@ skipping 312 matching lines @@
 void ExtensionSystemImpl::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const UnloadedExtensionInfo::Reason reason) {
   BrowserThread::PostTask(
       BrowserThread::IO,
       FROM_HERE,
       base::Bind(&InfoMap::RemoveExtension, info_map(), extension_id, reason));
 }
 
 }  // namespace extensions