Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: extensions/browser/content_hash_reader.cc

Issue 288273004: A bunch of remaining parts of extension content verification (Reland) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix browser test Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/content_hash_reader.h ('k') | extensions/browser/content_verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/content_hash_reader.cc
diff --git a/extensions/browser/content_hash_reader.cc b/extensions/browser/content_hash_reader.cc
index 9a327acd7b239b78950af2d7df574839ef3e1d3e..06c8ef0ab791916f005085c9e5bc78886f7ff933 100644
--- a/extensions/browser/content_hash_reader.cc
+++ b/extensions/browser/content_hash_reader.cc
@@ -4,6 +4,22 @@
#include "extensions/browser/content_hash_reader.h"
+#include "base/base64.h"
+#include "base/file_util.h"
+#include "base/json/json_reader.h"
+#include "base/strings/string_util.h"
+#include "base/values.h"
+#include "crypto/sha2.h"
+#include "extensions/browser/computed_hashes.h"
+#include "extensions/browser/content_hash_tree.h"
+#include "extensions/browser/verified_contents.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/file_util.h"
+
+using base::DictionaryValue;
+using base::ListValue;
+using base::Value;
+
namespace extensions {
ContentHashReader::ContentHashReader(const std::string& extension_id,
@@ -15,27 +31,79 @@ ContentHashReader::ContentHashReader(const std::string& extension_id,
extension_version_(extension_version.GetString()),
extension_root_(extension_root),
relative_path_(relative_path),
- key_(key) {
+ key_(key),
+ status_(NOT_INITIALIZED),
+ block_size_(0) {
}
ContentHashReader::~ContentHashReader() {
}
bool ContentHashReader::Init() {
+ DCHECK_EQ(status_, NOT_INITIALIZED);
+ status_ = FAILURE;
+ base::FilePath verified_contents_path =
+ file_util::GetVerifiedContentsPath(extension_root_);
+
+ if (!base::PathExists(verified_contents_path))
+ return false;
+
+ verified_contents_.reset(new VerifiedContents(key_.data, key_.size));
+ if (!verified_contents_->InitFrom(verified_contents_path, false) ||
+ !verified_contents_->valid_signature() ||
+ !verified_contents_->version().Equals(extension_version_) ||
+ verified_contents_->extension_id() != extension_id_) {
+ base::DeleteFile(verified_contents_path, false /* recursive */);
+ return false;
+ }
+
+ base::FilePath computed_hashes_path =
+ file_util::GetComputedHashesPath(extension_root_);
+ if (!base::PathExists(computed_hashes_path))
+ return false;
+
+ ComputedHashes::Reader reader;
+ if (!reader.InitFromFile(computed_hashes_path) ||
+ !reader.GetHashes(relative_path_, &block_size_, &hashes_) ||
+ block_size_ % crypto::kSHA256Length != 0) {
+ base::DeleteFile(computed_hashes_path, false /* recursive */);
+ return false;
+ }
+
+ std::string root =
+ ComputeTreeHashRoot(hashes_, block_size_ / crypto::kSHA256Length);
+ const std::string* expected_root = NULL;
+ expected_root = verified_contents_->GetTreeHashRoot(relative_path_);
+ if (expected_root && *expected_root != root) {
+ base::DeleteFile(computed_hashes_path, false /* recursive */);
+ return false;
+ }
+
+ status_ = SUCCESS;
return true;
}
int ContentHashReader::block_count() const {
- return 0;
+ DCHECK(status_ != NOT_INITIALIZED);
+ return hashes_.size();
}
int ContentHashReader::block_size() const {
- return 0;
+ DCHECK(status_ != NOT_INITIALIZED);
+ return block_size_;
}
bool ContentHashReader::GetHashForBlock(int block_index,
const std::string** result) const {
- return false;
+ if (status_ != SUCCESS)
+ return false;
+ DCHECK(block_index >= 0);
+
+ if (static_cast<unsigned>(block_index) >= hashes_.size())
+ return false;
+ *result = &hashes_[block_index];
+
+ return true;
}
} // namespace extensions
« no previous file with comments | « extensions/browser/content_hash_reader.h ('k') | extensions/browser/content_verifier.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698