Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2882683002:
Photo Picker Dialog: Add window enter animation. (Closed)
DescriptionPhoto Picker Dialog: Add window enter animation.
BUG=656015
Review-Url: https://codereview.chromium.org/2882683002
Cr-Commit-Position: refs/heads/master@{#471724}
Committed: https://chromium.googlesource.com/chromium/src/+/62809a64d70ec8b67847b3cefc03e4ba4bda0d3f
Patch Set 1 #
Total comments: 1
Patch Set 2 : Address feedback from Theresa #
Messages
Total messages: 22 (13 generated)
Description was changed from ========== TBD BUG= ========== to ========== Photo Picker Dialog: Add window enter animation. BUG=656015 ==========
finnur@chromium.org changed reviewers: + twellington@chromium.org
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm % moving style to values-v17 https://codereview.chromium.org/2882683002/diff/1/chrome/android/java/res/val... File chrome/android/java/res/values-v21/styles.xml (right): https://codereview.chromium.org/2882683002/diff/1/chrome/android/java/res/val... chrome/android/java/res/values-v21/styles.xml:146: <item name="android:windowEnterAnimation">@anim/design_bottom_sheet_slide_in</item> v21 is only used on Lollipop and higher. This should be defined in v17.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by finnur@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from twellington@chromium.org Link to the patchset: https://codereview.chromium.org/2882683002/#ps20001 (title: "Address feedback from Theresa")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
finnur@chromium.org changed reviewers: + miguelg@chromium.org
Miguel, do you mind doing an OWNERS check on the java file?
On 2017/05/12 17:52:55, Finnur wrote: > Miguel, do you mind doing an OWNERS check on the java file? And if it looks OK, feel free to check the CQ box.
lgtm
The CQ bit was checked by miguelg@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494842288049920,
"parent_rev": "4162a4dc23269a244e6a007e1126eeb4ad45ebf0", "commit_rev":
"62809a64d70ec8b67847b3cefc03e4ba4bda0d3f"}
Message was sent while issue was closed.
Description was changed from ========== Photo Picker Dialog: Add window enter animation. BUG=656015 ========== to ========== Photo Picker Dialog: Add window enter animation. BUG=656015 Review-Url: https://codereview.chromium.org/2882683002 Cr-Commit-Position: refs/heads/master@{#471724} Committed: https://chromium.googlesource.com/chromium/src/+/62809a64d70ec8b67847b3cefc03... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/62809a64d70ec8b67847b3cefc03... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
