chrome/android/java/res/values-v17/styles.xml - Issue 2882683002: Photo Picker Dialog: Add window enter animation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/values-v17/styles.xml

Issue 2882683002: Photo Picker Dialog: Add window enter animation. (Closed)

Patch Set: Address feedback from Theresa Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java » ('j') | no next file with comments »

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <resources xmlns:tools="http://schemas.android.com/tools">	6 <resources xmlns:tools="http://schemas.android.com/tools">

7 <!-- Q: Why put style resources under values-v17/ ?	7 <!-- Q: Why put style resources under values-v17/ ?

8 A: Problem:	8 A: Problem:

9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.	9 1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.

10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert	10 2. So we wrote a build script(generate_v14_compatible_resources.py) to convert

(...skipping 701 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
712 </style>	712 </style>

713 <style name="IncognitoNewTabLearnMoreLink">	713 <style name="IncognitoNewTabLearnMoreLink">

714 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>	714 <item name="android:background">?attr/listChoiceBackgroundIndicator</ite m>

715 <item name="android:clickable">true</item>	715 <item name="android:clickable">true</item>

716 <item name="android:focusable">true</item>	716 <item name="android:focusable">true</item>

717 <item name="android:textSize">14sp</item>	717 <item name="android:textSize">14sp</item>

718 <item name="android:textAllCaps">true</item>	718 <item name="android:textAllCaps">true</item>

719 <item name="android:padding">16dp</item>	719 <item name="android:padding">16dp</item>

720 </style>	720 </style>

721	721

	722 <!-- Photo Picker animations -->

	723

	724 <style name="PhotoPickerDialogAnimation">

	725 <item name="android:windowEnterAnimation">@anim/design_bottom_sheet_slid e_in</item>

	726 <item name="android:windowExitAnimation">@null</item>

	727 </style>

722 </resources>	728 </resources>

OLD	NEW