LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html - Issue 288263002: [New Multicolumn] Rebalance properly when child content changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html

Issue 288263002: [New Multicolumn] Rebalance properly when child content changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More cleanup; avoid bool arguments. Get rid of layout() override. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/multicol/change-block-child-height.html ('K') | « LayoutTests/fast/multicol/content-change-same-height-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash-expected.txt » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html

diff --git a/LayoutTests/fast/multicol/anonymous-block-split-crash.html b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html

similarity index 91%

copy from LayoutTests/fast/multicol/anonymous-block-split-crash.html

copy to LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html

index e029dbc2e434353485bdb639e87b42d63e1d1413..4de4ea8fe2d4f5d91836b2a6efaa869d3701eed8 100644

--- a/LayoutTests/fast/multicol/anonymous-block-split-crash.html

+++ b/LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html

@@ -10,6 +10,8 @@

if (window.testRunner)

testRunner.dumpAsText();

+if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

onload = function() {

test0 = document.createElement('div');

@@ -27,7 +29,7 @@ onload = function() {

test4 = document.createElement('table');

test4.setAttribute('id', 'test4');

test1.appendChild(test4);

- test0.style.display = 'run-in';

+ test0.style.display = 'run-in';

test4.style.display = 'table-column';

document.body.offsetTop;

document.designMode = 'on';