LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html - Issue 288263002: [New Multicolumn] Rebalance properly when child content changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html

Issue 288263002: [New Multicolumn] Rebalance properly when child content changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More cleanup; avoid bool arguments. Get rid of layout() override. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/multicol/change-block-child-height.html ('K') | « LayoutTests/fast/multicol/content-change-same-height-expected.txt ('k') | LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash-expected.txt » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <style>	3 <style>

4 #test0 { -webkit-column-count: 2; }	4 #test0 { -webkit-column-count: 2; }

5 #test1::after { display: block; content: ''; }	5 #test1::after { display: block; content: ''; }

6 #test2:nth-last-child(2n) { content: ''; }	6 #test2:nth-last-child(2n) { content: ''; }

7 #test2 { -webkit-column-span: all; }	7 #test2 { -webkit-column-span: all; }

8 #test4 { float: right; }	8 #test4 { float: right; }

9 </style>	9 </style>

10 <script>	10 <script>

11 if (window.testRunner)	11 if (window.testRunner)

12 testRunner.dumpAsText();	12 testRunner.dumpAsText();

	13 if (window.internals)

	14 internals.settings.setRegionBasedColumnsEnabled(true);

13	15

14 onload = function() {	16 onload = function() {

15 test0 = document.createElement('div');	17 test0 = document.createElement('div');

16 test0.setAttribute('id', 'test0');	18 test0.setAttribute('id', 'test0');

17 document.body.appendChild(test0);	19 document.body.appendChild(test0);

18 test1 = document.createElement('div');	20 test1 = document.createElement('div');

19 test1.setAttribute('id', 'test1');	21 test1.setAttribute('id', 'test1');

20 test0.appendChild(test1);	22 test0.appendChild(test1);

21 test2 = document.createElement('div');	23 test2 = document.createElement('div');

22 test2.setAttribute('id', 'test2');	24 test2.setAttribute('id', 'test2');

23 test1.appendChild(test2);	25 test1.appendChild(test2);

24 test3 = document.createElement('span');	26 test3 = document.createElement('span');

25 test1.appendChild(test3);	27 test1.appendChild(test3);

26 test3.appendChild(document.createTextNode('A'));	28 test3.appendChild(document.createTextNode('A'));

27 test4 = document.createElement('table');	29 test4 = document.createElement('table');

28 test4.setAttribute('id', 'test4');	30 test4.setAttribute('id', 'test4');

29 test1.appendChild(test4);	31 test1.appendChild(test4);

30 test0.style.display = 'run-in';	32 test0.style.display = 'run-in';

31 test4.style.display = 'table-column';	33 test4.style.display = 'table-column';

32 document.body.offsetTop;	34 document.body.offsetTop;

33 document.designMode = 'on';	35 document.designMode = 'on';

34 document.execCommand('selectall');	36 document.execCommand('selectall');

35 document.execCommand('inserttext', '');	37 document.execCommand('inserttext', '');

36 document.body.offsetTop;	38 document.body.offsetTop;

37 document.body.innerHTML = "PASS";	39 document.body.innerHTML = "PASS";

38 }	40 }

39 </script>	41 </script>

40 </head>	42 </head>

41 <body>	43 <body>

42 </body>	44 </body>

43 </html>	45 </html>

OLD	NEW