LayoutTests/fast/multicol/change-block-child-height.html - Issue 288263002: [New Multicolumn] Rebalance properly when child content changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/multicol/change-block-child-height.html

Issue 288263002: [New Multicolumn] Rebalance properly when child content changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More cleanup; avoid bool arguments. Get rid of layout() override. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/change-block-child-height-expected.html » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/change-block-child-height.html

diff --git a/LayoutTests/fast/multicol/change-block-child-height.html b/LayoutTests/fast/multicol/change-block-child-height.html

new file mode 100644

index 0000000000000000000000000000000000000000..1cc3ae604a91aacc0889b06984f227ad32a38f19

--- /dev/null

+++ b/LayoutTests/fast/multicol/change-block-child-height.html

@@ -0,0 +1,16 @@

+<!DOCTYPE html>

+<script>

+ if (window.internals)

+ internals.settings.setRegionBasedColumnsEnabled(true);

+ onload = function() {

+ document.body.offsetTop; // trigger layout

+ document.getElementById('elm').style.height = '0';

+ }

+</script>

+<p>There should be a blue <em>square</em> below.</p>

Julien - ping for review 2014/05/23 09:07:54 With no red?

mstensho (USE GERRIT) 2014/05/23 11:46:09 Done.

+<div style="-webkit-columns:3; columns:3; -webkit-column-gap:0; column-gap:0; width:9em; line-height:9em; background:blue;">

+ <br>

+ <div id="elm" style="height:10em; background:red;"></div>

+ <br>

+</div>

« no previous file with comments | « no previous file | LayoutTests/fast/multicol/change-block-child-height-expected.html » ('j') | Source/core/rendering/RenderMultiColumnFlowThread.cpp » ('J')