Implemented remaining non-grouped longhand property APIs

Implemented remaining non-grouped longhand property APIs

Added the property APIs and implemented the parseSingleValue method on
the remaining longhand non-grouped properties that did not have stub API
implementations.

This includes the following properties:
- animation-direction
- animation-fill-mode
- animation-iteration-count
- animation-play-state
- background-color
- box-shadow
- font-weight
- object-position
- perspective-origin
- text-shadow
- transition-property
- webkit-box-reflect

BUG=668012
Review-Url: https://codereview.chromium.org/2882603002
Cr-Commit-Position: refs/heads/master@{#481115}
Committed: https://chromium.googlesource.com/chromium/src/+/fbee2d97beece9b3b4dea2181019621a9f5299fb

[Bugs Nash, 2017-05-12 06:12:48]

Description was changed from

==========
WIP add missing stub property APIs

BUG=
==========

to

==========
WIP add missing stub property APIs

Also removes a grouped api CSSPropertyAPIShadow that is no longer grouped due to
refactors

BUG=
==========

[Bugs Nash, 2017-06-08 06:52:15]

bugsnash@chromium.org changed reviewers:
+ jiameng@chromium.org, meade@chromium.org

[Bugs Nash, 2017-06-08 06:52:16]

FYI

[Bugs Nash, 2017-06-08 06:54:36]

On 2017/06/08 at 06:52:16, Bugs Nash wrote:
> FYI

whoops didn't mean to send yet.

No review required, just an FYI for my WIP. Feel free to give WIP comments if
you wish!

This is the current status of scripted creation of apis. This patch only
includes single property apis, but grouped apis are also in the works. This
currently won't compile as #includes and CSSPropertyParserHelpers:: prefixes are
required in some places.

[Bugs Nash, 2017-06-08 06:55:12]

bugsnash@chromium.org changed reviewers:
+ rjwright@chromium.org

[Bugs Nash, 2017-06-08 06:55:13]

+rjwright

[Bugs Nash, 2017-06-08 06:57:44]

Description was changed from

==========
WIP add missing stub property APIs

Also removes a grouped api CSSPropertyAPIShadow that is no longer grouped due to
refactors

BUG=
==========

to

==========
WIP implement remaining property APIs

BUG=668012
==========

[Bugs Nash, 2017-06-08 07:00:58]

On 2017/06/08 at 06:55:13, Bugs Nash wrote:
> +rjwright

oh, and this patch also doesn't currently implement the apis of the stubs that
anna has already added

[Jia, 2017-06-08 22:07:14]

I understand your cl is a bulk API impl for longhand properties. However, there
are two shorthand properties in this cl, and they implement parseSingleValue.
Please either remove these two properties from your cl if you didn't intend to
impl shorthand APIs, or, change parseSingleValue to parseShorthand for them (and
also change their names to CSSShorthandPropertyAPI<property_name>. If the
latter, you'll need to patch in my cl (crrev.com/2932663002), which contains
templates and scripts for shorthand property API generation.

See also detailed comments inline.

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (left):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3308: case
CSSPropertyBorderColor:
This is a shorthand property

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3375: case
CSSPropertyGridGap: {
A shorthand property

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderColor.cpp
(right):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderColor.cpp:14:
const CSSValue* CSSPropertyAPIBorderColor::parseSingleValue(
This is a shorthand and should impl parseShorthand.

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIBorderColor.cpp:18:
return Consume4Values(borderColorShorthand(), important);
This is a private function of CSSPropertyParser.cpp, I don't think the code
would compile.

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp
(right):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp:14:
const CSSValue* CSSPropertyAPIGridGap::parseSingleValue(
This is a shorthand, it should impl parseShorthand.

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp:29:
important);
AddParsedProperty is a wrapper function private to CSSPropertyParser. I don't
think the code would compile.

[Bugs Nash, 2017-06-09 00:00:17]

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (left):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3308: case
CSSPropertyBorderColor:
On 2017/06/08 at 22:07:13, Jia wrote:
> This is a shorthand property

good spot, there was a bug in my input! this represents a shorthand name
conflicting with a group name (from the burndown spreadsheet). these group names
need a rethink

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp
(right):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp:29:
important);
On 2017/06/08 at 22:07:14, Jia wrote:
> AddParsedProperty is a wrapper function private to CSSPropertyParser. I don't
think the code would compile.

no this code certainly doesn't compile! as I mentioned before, this is an FYI
for a WIP. many compile errors like this need to be fixed yet (mostly #includes
and CSPropertyParserHelpers prefixes)

[Jia, 2017-06-09 00:10:07]

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (left):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3308: case
CSSPropertyBorderColor:
On 2017/06/09 00:00:17, Bugs Nash wrote:
> On 2017/06/08 at 22:07:13, Jia wrote:
> > This is a shorthand property
> 
> good spot, there was a bug in my input! this represents a shorthand name
> conflicting with a group name (from the burndown spreadsheet). these group
names
> need a rethink

You can keep the group names the same as before, because we'll use
CSSShortPropertyAPI<property_name> for shorthands, so there won't be any
conflict.

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp
(right):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/properties/CSSPropertyAPIGridGap.cpp:29:
important);
On 2017/06/09 00:00:17, Bugs Nash wrote:
> On 2017/06/08 at 22:07:14, Jia wrote:
> > AddParsedProperty is a wrapper function private to CSSPropertyParser. I
don't
> think the code would compile.
> 
> no this code certainly doesn't compile! as I mentioned before, this is an FYI
> for a WIP. many compile errors like this need to be fixed yet (mostly
#includes
> and CSPropertyParserHelpers prefixes)

Ok, so I don't need to lgtm for now. Thanks for the headsup!

[Bugs Nash, 2017-06-09 05:02:11]

Still just an FYI and a WIP

Fixed the shorthand issue spotted by Jia, fixed a bunch of build errors, and
started moving methods to apis. this is now blocked on utils files being
implemented (which I am doing now)

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (left):

https://codereview.chromium.org/2882603002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3308: case
CSSPropertyBorderColor:
On 2017/06/09 at 00:10:07, Jia wrote:
> On 2017/06/09 00:00:17, Bugs Nash wrote:
> > On 2017/06/08 at 22:07:13, Jia wrote:
> > > This is a shorthand property
> > 
> > good spot, there was a bug in my input! this represents a shorthand name
> > conflicting with a group name (from the burndown spreadsheet). these group
names
> > need a rethink
> 
> You can keep the group names the same as before, because we'll use
CSSShortPropertyAPI<property_name> for shorthands, so there won't be any
conflict.

Ah, good to know. I think for clarity it would still be better to rename all the
grouped properties to CSSGroupedPropertyAPI<group_name>, but not required
urgently.

This problem has now been fixed in this patch

[Bugs Nash, 2017-06-13 05:49:09]

rebased and fixed more errors

[Bugs Nash, 2017-06-13 22:05:31]

rebased and fixed build errors

[meade_UTC10, 2017-06-14 03:11:07]

Hey this is looking really good already. I'm ok to lgtm :)

[Bugs Nash, 2017-06-16 06:02:00]

rebased

[Bugs Nash, 2017-06-20 00:22:48]

rebased on utils

[Bugs Nash, 2017-06-21 01:58:04]

rebased onto final utils

[Bugs Nash, 2017-06-21 01:58:10]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 01:58:31]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-06-21 02:03:47]

Description was changed from

==========
WIP implement remaining property APIs

BUG=668012
==========

to

==========
Implemented remaining non-grouped longhand property APIs

Added the property APIs and implemented the parseSingleValue method on
the remaining longhand non-grouped properties that did not have stub API
implementations.

This includes the following properties:
- animation-direction
- animation-fill-mode
- animation-iteration-count
- animation-play-state
- background-color
- box-shadow
- font-weight
- object-position
- perspective-origin
- text-shadow
- transition-property
- webkit-box-reflect

BUG=668012
==========

[commit-bot: I haz the power, 2017-06-21 04:28:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 04:28:44]

Dry run: This issue passed the CQ dry run.

[Bugs Nash, 2017-06-21 05:30:00]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-06-21 05:30:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
jiameng@chromium.org, meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2882603002/#ps140001
(title: "rebased onto final utils")

[commit-bot: I haz the power, 2017-06-21 05:30:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 05:34:50]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1498023000345560,
"parent_rev": "9c70225b2a1ab3982b2c6345cc46f2d96bad025b", "commit_rev":
"fbee2d97beece9b3b4dea2181019621a9f5299fb"}

[commit-bot: I haz the power, 2017-06-21 05:35:04]

Description was changed from

==========
Implemented remaining non-grouped longhand property APIs

Added the property APIs and implemented the parseSingleValue method on
the remaining longhand non-grouped properties that did not have stub API
implementations.

This includes the following properties:
- animation-direction
- animation-fill-mode
- animation-iteration-count
- animation-play-state
- background-color
- box-shadow
- font-weight
- object-position
- perspective-origin
- text-shadow
- transition-property
- webkit-box-reflect

BUG=668012
==========

to

==========
Implemented remaining non-grouped longhand property APIs

Added the property APIs and implemented the parseSingleValue method on
the remaining longhand non-grouped properties that did not have stub API
implementations.

This includes the following properties:
- animation-direction
- animation-fill-mode
- animation-iteration-count
- animation-play-state
- background-color
- box-shadow
- font-weight
- object-position
- perspective-origin
- text-shadow
- transition-property
- webkit-box-reflect

BUG=668012

Review-Url: https://codereview.chromium.org/2882603002
Cr-Commit-Position: refs/heads/master@{#481115}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbee2d97beece9b3b4dea2181019...
==========

[commit-bot: I haz the power, 2017-06-21 05:35:06]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/fbee2d97beece9b3b4dea2181019...